New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix includes in RecoLocalCalo/HGCalRecAlgos. #19160
Fix includes in RecoLocalCalo/HGCalRecAlgos. #19160
Conversation
We use std::vector in KDTreeLinkerTools.h, so we also need to include the corresponding STL header to make this header compile. In HGCalRecHitSimpleAlgo.h we use cms::Exception, so here we also need to include the relevant header Exception.h.
Part of the work going on regarding issue #15248 |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: RecoLocalCalo/HGCalRecAlgos @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
We use std::vector in KDTreeLinkerTools.h, so we also need to
include the corresponding STL header to make this header compile.
In HGCalRecHitSimpleAlgo.h we use cms::Exception, so here we also
need to include the relevant header Exception.h.