New CaloL{1,2} LUTs are taken care of by the L1T O2O #19164
Conversation
|
A new Pull Request was created by @kkotov (Khristian Kotov) for master. It involves the following packages: CondFormats/DataRecord @ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@rekovic , could you sign-off no this PR? |
|
+1 |
|
@ggovi , could you review and sign-off this small PR? From the AlCa/DB point of view it only modifies one existing record (changes dependent record list): CondFormats/DataRecord/interface/L1TCaloParamsO2ORcd.h |
|
+1 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
|
||
| int regionPUSValue(int PUM0, int eta) | ||
| { | ||
| int puSub = ceil(regionPUSParams()[18*eta+PUM0]*2); |
There was a problem hiding this comment.
hi @kkotov - please document the meaning of 18 in a followup pr. thanks
|
+1 |
This PR supersedes PR #18872.
It includes recent development of CaloL2 including tauTrimmingVeto LUT and several commits for removing Stage2 from CaloParams record names.