Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add possibility of using getPU_NumInteractions #19166

Merged
merged 3 commits into from Mar 6, 2019
Merged

add possibility of using getPU_NumInteractions #19166

merged 3 commits into from Mar 6, 2019

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jun 9, 2017

as discussed w/ tracking POG
there is the need of selecting events by using getPU_NumInteractions
@makortel

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Jun 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

PhysicsTools/Utilities

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20516/console Started: 2017/06/13 09:30

@cmsbuild
Copy link
Contributor

+1
Tested at: b027385
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19166/20516/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19166/20516/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 34645
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783047
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@smuzaffar smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017
@smuzaffar smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_9_3_X Sep 6, 2017
@smuzaffar smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_10_0_X Oct 26, 2017
@cmsbuild cmsbuild modified the milestones: CMSSW_10_0_X, CMSSW_9_4_X Oct 26, 2017
@mtosi
Copy link
Contributor Author

mtosi commented Mar 5, 2019

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-19166/8633

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33420/console Started: 2019/03/05 18:33

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Pull request #19166 was updated. @cmsbuild, @santocch can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

+1
Tested at: 04ab095
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19166/33420/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19166/33420/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114826
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Mar 6, 2019

@mtosi thank you, @santocch FYI, I would like to merge it and finally close it, unless you have further comments

@santocch
Copy link

santocch commented Mar 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 6, 2019

+1

@cmsbuild cmsbuild merged commit 07aa62e into cms-sw:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_6_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mtosi @cmsbuild @davidlange6 @fabiocos @santocch @smuzaffar