New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding useful channel id mappings #19187
Conversation
A new Pull Request was created by @igv4321 (Igor Volobouev) for master. It involves the following packages: CondFormats/HcalObjects @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@ggovi Ping... This is a relatively trivial PR. Please test and approve. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
This modification allows to group Hcal channels by eta and depth for writing calibration constants with "HcalItemCollById" collections.
There are no such entries in the CMS database yet, so this modification will not change any existing relval results.