Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding useful channel id mappings #19187

Merged
merged 1 commit into from Jun 21, 2017

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Jun 10, 2017

This modification allows to group Hcal channels by eta and depth for writing calibration constants with "HcalItemCollById" collections.

There are no such entries in the CMS database yet, so this modification will not change any existing relval results.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

CondFormats/HcalObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@igv4321
Copy link
Contributor Author

igv4321 commented Jun 12, 2017

@ggovi Ping... This is a relatively trivial PR. Please test and approve.

@arunhep
Copy link
Contributor

arunhep commented Jun 13, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20520/console Started: 2017/06/13 11:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19187/20520/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 34620
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783072
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Jun 13, 2017

+1

@igv4321
Copy link
Contributor Author

igv4321 commented Jun 16, 2017

@cerminar @arunhep Could we please get this PR going? It is very simple and will not take much of your time.

@igv4321
Copy link
Contributor Author

igv4321 commented Jun 20, 2017

@mmusich Who is the AlCa person really responsible for PR reviews these days? This PR, in its essence, is very similar to PR #15627 that you approved at that time on the AlCa side.

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2017

Hi @igv4321,
Giovanni @franzoni and Arun @arunhep are responsibles for the AlCa signature.
Your changes here look OK to me, I guess they are currently very busy with the preparation of the conditions for 2017 Physiscs MC production and might have overlooked this PR.

@arunhep
Copy link
Contributor

arunhep commented Jun 20, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cc3cba4 into cms-sw:master Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants