Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2-hgx85 Correct for overwriting (as reported in PR #19179) #19198

Merged
merged 2 commits into from Jun 15, 2017
Merged

Phase2-hgx85 Correct for overwriting (as reported in PR #19179) #19198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1022ae2
Correct for overwriting
Jun 12, 2017
84a5122
Take Slava's comments
Jun 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions RecoLocalCalo/HGCalRecAlgos/interface/HGCalImagingAlgo.h
View file
Open in desktop
Expand Up @@ -112,10 +112,10 @@ HGCalImagingAlgo(const std::vector<double>& vecDeltas_in, double kappa_in, doubl
verbosity(the_verbosity),
initialized(false),
points(2*(maxlayer+1)),
minpos(2*(maxlayer+1),{
minpos(2*(maxlayer+1),{
{0.0f,0.0f}
}),
maxpos(2*(maxlayer+1),{ {0.0f,0.0f} })
maxpos(2*(maxlayer+1),{ {0.0f,0.0f} })
{
}

Expand Down Expand Up @@ -164,12 +164,11 @@ static const unsigned int maxlayer = 52;


private:

// last layer per subdetector
static const unsigned int lastLayerEE = 28;
static const unsigned int lastLayerFH = 40;
// maximum number of wafers per Layer: 666 (V7), 794 (V8)
static const unsigned int maxNumberOfWafersPerLayer = 794;
static const unsigned int maxNumberOfWafersPerLayer = 796;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the text in the comments above: it still says 794. If instead this 796 corresponds to 794 precisely, please add a few words why.


// The two parameters used to identify clusters
std::vector<double> vecDeltas;
Expand Down