Avoid freeing memory owned by TMVA::Reader

[smuzaffar]

This was noticed by valgrid #19179 (comment)
It is same issue mentioned here #17266

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20539/console Started: 2017/06/13 17:17

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

RecoEgamma/PhotonIdentification

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @rafaellopesdesa, @lgray this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Leaking memory at the beginning of the job doesn't look like a good solution to me.

[cmsbuild]

+1
Tested at: 6b0e61e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19207/20539/summary.html

[cmsbuild]

Comparison job queued.

[smuzaffar]

@Dr15Jones , why you think it is a memory leak? TMVA::Reader destructor (https://github.com/root-project/root/blob/4fa59f4fb80fd914cb84144e5218e55397810c01/tmva/tmva/src/Reader.cxx#L289) is going to free it at the end of this function

[lgray]

Indeed, looks like they fixed that problem...

[lgray]

Yeah fixed here: root-project/root@e220608

[Dr15Jones]

I withdraw my objection. The version of BookMVA we call does have the memory cleaned up. The other public version which we are not calling in this code does not clean up its memory:
https://github.com/cms-sw/root/blob/cms/v6-08-06/tmva/tmva/src/Reader.cxx#L439

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19207/20539/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1817858
• DQMHistoTests: Total failures: 19740
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1797952
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[slava77]

+1

for #19207 6b0e61e

• the same change as was done in the past in e.g. https://github.com/cms-sw/cmssw/pull/17266/files#diff-5ec5d166fbe4a06101a391228700a62bL187
• jenkins tests pass (Reco comparison results: 0 differences found in the comparisons)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1