Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TIB|TOB|TID|TEC|PXB|PXF)DetId deprecation: remove unnecessary includes #19208

Merged

Conversation

pieterdavid
Copy link
Contributor

Purely technical change, the deprecated classes seem not to be used in these places (and the code compiles when removing them).
Apologies for touching a bunch of unrelated packages in one pull request, we'll keep the other changes more localized.

cc @vidalm @alesaggio @OlivierBondu

pieterdavid and others added 4 commits June 13, 2017 17:07
- RecoEgamma/EgammaHLTProducers/src/EgammaHLTPixelMatchVarProducer.cc
- RecoHI/HiCentralityAlgos/plugins/CentralityProducer.cc
- SimTracker/SiPixelDigitizer/test/PixelSimHitsTest.cc
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pieterdavid (Pieter David) for master.

It involves the following packages:

DPGAnalysis/SiStripTools
DQM/TrackingMonitor
DataFormats/TrackReco
DataFormats/TrackerCommon
RecoEgamma/EgammaHLTProducers
RecoHI/HiCentralityAlgos
SimTracker/SiPixelDigitizer
TrackingTools/TrackAssociator

@perrotta, @cmsbuild, @civanch, @monttj, @silviodonato, @fwyzard, @mdhildreth, @dmitrijus, @Martin-Grunewald, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @fioriNTU, @threus, @venturia, @azsigmon, @hdelanno, @battibass, @makortel, @sdevissc, @jhgoh, @lgray, @yenjie, @trocino, @yetkinyilmaz, @Sam-Harper, @GiacomoSguazzoni, @rafaellopesdesa, @rovere, @VinInn, @bellan, @idebruyn, @ebrondol, @mtosi, @dgulhan, @HuguesBrun, @mandrenguyen, @jazzitup, @calderona, @dkotlins, @kurtejung, @gpetruc this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20542/console Started: 2017/06/13 17:35

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19208/20542/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 5240
  • DQMHistoTests: Total nulls: 10
  • DQMHistoTests: Total successes: 1812442
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2017

+1

for #19208 66bb3bf

  • technical
  • jenkins tests pass

@civanch
Copy link
Contributor

civanch commented Jun 14, 2017

+1

@Martin-Grunewald
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b73985a into cms-sw:master Jun 14, 2017
@OlivierBondu
Copy link
Contributor

tracked at #19398

@pieterdavid pieterdavid deleted the removeSiStripSubDetId_unusedincludes branch September 28, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants