New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(TIB|TOB|TID|TEC|PXB|PXF)DetId deprecation: remove unnecessary includes #19208
(TIB|TOB|TID|TEC|PXB|PXF)DetId deprecation: remove unnecessary includes #19208
Conversation
- RecoEgamma/EgammaHLTProducers/src/EgammaHLTPixelMatchVarProducer.cc - RecoHI/HiCentralityAlgos/plugins/CentralityProducer.cc - SimTracker/SiPixelDigitizer/test/PixelSimHitsTest.cc
A new Pull Request was created by @pieterdavid (Pieter David) for master. It involves the following packages: DPGAnalysis/SiStripTools @perrotta, @cmsbuild, @civanch, @monttj, @silviodonato, @fwyzard, @mdhildreth, @dmitrijus, @Martin-Grunewald, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
merge |
tracked at #19398 |
Purely technical change, the deprecated classes seem not to be used in these places (and the code compiles when removing them).
Apologies for touching a bunch of unrelated packages in one pull request, we'll keep the other changes more localized.
cc @vidalm @alesaggio @OlivierBondu