Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx86 Fix the bug for overwriting (backport from 9_2_X #19198) #19209

Merged
merged 2 commits into from Jun 15, 2017

Conversation

bsunanda
Copy link
Contributor

Use correct # for maximum wafers

@cmsbuild cmsbuild added this to the CMSSW_9_1_X milestone Jun 13, 2017
@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20550/console Started: 2017/06/13 18:44

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_9_1_X.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos

@perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @argiro, @cseez, @pfs, @lgray this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@kpedro88
Copy link
Contributor

Backport of #19198

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19209/20550/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1681 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1834259
  • DQMHistoTests: Total failures: 8530
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1825549
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #19209 was updated. @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20568/console Started: 2017/06/14 16:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19209/20568/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1695 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1834225
  • DQMHistoTests: Total failures: 27227
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1806818
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 15, 2017

+1

for #19209 9b8b88a

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7807fa5 into cms-sw:CMSSW_9_1_X Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants