Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hlt tau validation update cmssw92 x june2017 #19216

Merged

Conversation

slehti
Copy link
Contributor

@slehti slehti commented Jun 14, 2017

As requested in PR #18172, changed bool tagAndProbe -> tagAndProbe_
One bug fix.
Added tag&probe monitoring for the lepton legs of the lepton+tau triggers.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slehti for master.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@mtosi
Copy link
Contributor

mtosi commented Jun 14, 2017

tracked by #19142

@mtosi mtosi mentioned this pull request Jun 14, 2017
@mtosi
Copy link
Contributor

mtosi commented Jun 14, 2017

TSG google doc has been updated ;)
thanks

@cmsbuild
Copy link
Contributor

Pull request #19216 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20610/console Started: 2017/06/15 17:23

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19216/20610/summary.html

Comparison Summary:

  • You potentially added 55 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1792340
  • DQMHistoTests: Total failures: 29845
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1762329
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #19216 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

@slehti
Copy link
Contributor Author

slehti commented Jun 16, 2017

The 3.14 or 3.15 is only for the histogram plotting region. Changed to +-3.15.

@cmsbuild
Copy link
Contributor

Pull request #19216 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20875/console Started: 2017/06/23 14:09

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19216/20875/summary.html

Comparison Summary:

  • You potentially added 57 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1792052
  • DQMHistoTests: Total failures: 29452
  • DQMHistoTests: Total nulls: 24
  • DQMHistoTests: Total successes: 1762410
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1
even if phi really does go from -pi to pi..

@cmsbuild cmsbuild merged commit e1556d0 into cms-sw:master Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants