Fix filter logic error: redundant produce (92X) #19217
Conversation
|
A new Pull Request was created by @afiqaize (Afiq Anuar) for master. It involves the following packages: HLTrigger/Egamma @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@cmsbuild please test |
| @@ -91,7 +91,7 @@ HLTEgammaGenericQuadraticEtaFilter::HLTEgammaGenericQuadraticEtaFilter(const edm | |||
| } | |||
|
|
|||
| //register your products | |||
| produces<trigger::TriggerFilterObjectWithRefs>(); | |||
| //produces<trigger::TriggerFilterObjectWithRefs>(); | |||
There was a problem hiding this comment.
please remove the line instead of commenting it
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Pull request #19217 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
Hi,
This commit is to fix the logic error in the filter. Otherwise it gives [1]. Probably escaped attention as this filter isn't in use in the current menu.
Cheers,
Afiq
[1]
----- Begin Fatal Exception 13-Jun-2017 17:32:55 CEST-----------------------
An exception of category 'LogicError' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=HLTEgammaGenericQuadraticEtaFilter label='hltEle27WPTight1HEFilter'
Exception Message:
Duplicate Product The produced product Branch Type = Event
Process Name = MYHLT
ModuleLabel = hltEle27WPTight1HEFilter
Branch ID = 1294368331
Class Name = trigger::TriggerFilterObjectWithRefs
Friendly Class Name = triggerTriggerFilterObjectWithRefs
Product Instance Name =
is registered more than once.
Please remove the redundant 'produces' call(s).
----- End Fatal Exception -------------------------------------------------