Include FWEventItem.h instead of using forward decl. FWEventItem #19230
Conversation
We cannot use FWEventItem via forward declaration in these two cases as we call method on FWEventItem. For that you need a complete type. This resolves majority of warnings in Fireworks under GCC 7.1.1. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for master. It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
fully-signed
visualization-approved
and removed
pending-signatures
visualization-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-approved
and removed
comparison-pending
tests-started
labels
|
+1 |
We cannot use FWEventItem via forward declaration in these two cases as
we call method on FWEventItem. For that you need a complete type.
This resolves majority of warnings in Fireworks under GCC 7.1.1.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch