Fix || operator usage in conditional statements #19231
Conversation
This resolves 4 warnings from GCC 7.1.1 where we most likely have a wrong usage of || operator in our conditional statements. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for master. It involves the following packages: CalibTracker/SiPixelConnectivity @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
@davidlt tests-started label is there for 4 days. I see this in many other PRs. In those, I aborted the tests and started again. I hope this is the right thing to do. |
|
@cmsbuild please abort |
|
Jenkins tests are aborted. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
| @@ -684,7 +684,7 @@ void SiStripGainFromCalibTree::algoBeginJob(const edm::EventSetup& iSetup) | |||
| for(unsigned int i=0;i<Det.size();i++){ //Make two loop such that the Pixel information is added at the end --> make transition simpler | |||
| DetId Detid = Det[i]->geographicalId(); | |||
| int SubDet = Detid.subdetId(); | |||
| if( SubDet == PixelSubdetector::PixelBarrel || PixelSubdetector::PixelEndcap ){ | |||
| if( SubDet == PixelSubdetector::PixelBarrel || SubDet == PixelSubdetector::PixelEndcap ){ | |||
There was a problem hiding this comment.
regarding this particular line of the fix, together with the other two similar occurrences in the other classes in the same package, this actually alters the behavior of the code but thanks to the protection few lines below: https://github.com/cms-sw/cmssw/pull/19231/files#diff-5b549e5390591af6a4ae6ece2166765bR689, there is no issue with previous versions of the calibrations.
|
+1 |
This resolves 4 warnings from GCC 7.1.1 where we most likely have a
wrong usage of || operator in our conditional statements.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch