move max iterations message to LogDebug #19242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for master. It involves the following packages: RecoLocalCalo/EcalRecAlgos @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
remind me - are LogDebugs effectively no-ops?
…
|
|
On 6/15/17 8:34 AM, David Lange wrote:
remind me - are LogDebugs effectively no-ops?
https://github.com/cms-sw/cmssw/blob/master/FWCore/MessageLogger/interface/MessageLogger.h#L502-L509
it is a bit more than no-op, but it's pretty close.
…
> On Jun 15, 2017, at 3:18 PM, Slava Krutelyov ***@***.***> wrote:
>
> @cmsbuild please test
>
> @fwyzard
> I suppose that master is enough for this issue. Please confirm.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19242 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbtC43qKG1dECwDJHXuJZyNQx-9hKks5sEU7xgaJpZM4N7Jko>.
|
|
Comparison is ready Comparison Summary:
|
|
Assuming the 100s per event are soon to go away that is probably ok
Cheers,
David
On 15 Jun 2017, at 18:56, Slava Krutelyov ***@***.******@***.***>> wrote:
On 6/15/17 8:34 AM, David Lange wrote:
remind me - are LogDebugs effectively no-ops?
https://github.com/cms-sw/cmssw/blob/master/FWCore/MessageLogger/interface/MessageLogger.h#L502-L509
it is a bit more than no-op, but it's pretty close.
> On Jun 15, 2017, at 3:18 PM, Slava Krutelyov ***@***.******@***.***>> wrote:
>
> @cmsbuild please test
>
> @fwyzard
> I suppose that master is enough for this issue. Please confirm.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19242 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbtC43qKG1dECwDJHXuJZyNQx-9hKks5sEU7xgaJpZM4N7Jko>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#19242 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywzY0IoTekFziqpZVGKLWNgtjAWAHks5sEWIxgaJpZM4N7Jko>.
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
Sure, master is fine, thank you.
.A
|
|
+1 |
cmsbuild
added a commit
that referenced
this pull request
Jun 16, 2017
move max iterations message to LogDebug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving max iterations message to LogDebug, since in the first runs of 2017 (full MF enabled for 100% of hits) is flooding logfiles, see this HN.
Privately will check if this is by change related to some conditions (pedestal, pulse shape) for any channel slightly off.
@bendavid @amassiro @fwyzard also follow this