Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing link dependency #1925

Merged
merged 1 commit into from Dec 28, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 27, 2013

The standalone tool edmProvDump needs the dictionaries in DataFormats/WrappedStdDictionaries to function properly. This link dependency was missing from the build file. The tool depended on automatic loading of dictionaries to dynamically load these dictionaries. This pull request simply adds the missing link dependency.

ktf added a commit that referenced this pull request Dec 28, 2013
ROOT6 -- Add missing link dependency
@ktf ktf merged commit bd25e86 into cms-sw:CMSSW_7_0_ROOT6_X Dec 28, 2013
@ktf
Copy link
Contributor

ktf commented Dec 28, 2013

Is this ROOT6 specific?

@wmtan
Copy link
Contributor Author

wmtan commented Dec 28, 2013

The need for it is ROOT6 specific. It is not yet fully understood why the dictionary is not automatically loaded in ROOT6.
This will not break ROOT5, but it may cause a library to be linked in unnecessarily.
In hindsight, the description of this pull request above is actually wrong. edmProvDump needs DataFormats/WrappedStdDictionaries if and only if the file being dumped contains an object of a built in or an STL container of a built-in. In a framework unit test, this is the case, and the test fails without this request.
We should figure out why edmPluginDump does not load the dictionary automatically in ROOT6.
In hindsight, this may be a workaround rather than a real fix. So, I don't think it should be added for ROOT5.

@wmtan wmtan deleted the AddMissingLinkDependency branch December 31, 2013 16:03
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 1, 2014

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

Add missing link dependency

It involves the following packages:

IOPool/Common

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor

+1

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update data for RecoJets/JetProducers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants