Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2017 METplusTrack paths #19252

Merged
merged 1 commit into from Jun 22, 2017

Conversation

bpfrancis
Copy link
Contributor

This PR updates the path names in the offline exotica validation for the METXX_IsoTrk50 triggers, to be included in the 2017 pp collision menu.

TSG approval slides: https://indico.cern.ch/event/646747/contributions/2626978/attachments/1476569/2287752/bfrancis_OSU_TSG.pdf

@cmsbuild cmsbuild changed the base branch from CMSSW_9_2_X to master June 15, 2017 16:00
@cmsbuild
Copy link
Contributor

@bpf6qc, CMSSW_9_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bpf6qc (Brian Francis) for master.

It involves the following packages:

HLTriggerOffline/Exotica

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@mtosi this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@mtosi
Copy link
Contributor

mtosi commented Jun 15, 2017

this code is run in the VALIDATION step during the MC relval production
@dmitrijus can we please test this change ?
(even if we are still not having such a menu in the release ...)

let me remind you that in order to have a path in the online menu,
the DQM code/configuration has to be committed

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20816/console Started: 2017/06/21 15:21

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19252/20816/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1802848
  • DQMHistoTests: Total failures: 104
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1802578
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4e50f86 into cms-sw:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants