New feature in ME0 simulation: ME0PadDigiCluster #19254
Conversation
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: DataFormats/GEMDigi @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 2ccc20b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@civanch Could you run the tests again please? |
|
please test |
| std::vector<uint16_t> cl; | ||
| int startBX = 99; | ||
| for (auto d = pads.first; d != pads.second; ++d) { | ||
| if (cl.size() == 0) { |
There was a problem hiding this comment.
hi @dildick - please use if ( cl.empty() )
|
Pull request #19254 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @davidlange6 can you please check and sign again. |
|
Pull request #19254 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
dildick
deleted the
from-CMSSW_9_2_X_2017-06-15-1100-me0-pad-digi-cluster
branch
The ME0 optohybrid concentrator card (on-detector electronics) compresses trigger bits in the same way as for GEM. It will combine at most 8 adjacent ME0 pads into a cluster (ME0PadDigiCluster). Clusters will be sent to a CTP7 (which actually handles 3 ME0 super chambers). The CTP7 declusterizes them into single pads to be used as inputs for the ME0 pattern finding. This will be done in the ME0Motherboard in simulation.
Unlike GEM, ME0PadDigiCluster will not be sent to the track-finder directly nor to the nearby CSC optical trigger motherboard. ME0TriggerDigis will only be sent to the track-finder.
I also added the field "partition" to the ME0TriggerDigi dataformat. From the single pads in each layer it will be possible to the partition in the 3rd layer (which is likely going to be reference layer).
More information on the ME0 trigger system can be found here: https://indico.cern.ch/event/640240/contributions/2605361/attachments/1476748/2288198/MuonEndcap_SvenDildick_HLLHC_Trigger_Upgrade_20170614.pdf, slides 12-19
@calabria FYI