Run2-sim09 Record particle flux in selected volumes #19258

bsunanda · 2017-06-15T20:02:10Z

Useful to study detector design in specific regions

bsunanda · 2017-06-15T20:02:26Z

cmsbuild · 2017-06-15T20:02:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20617/console Started: 2017/06/15 22:04

cmsbuild · 2017-06-15T20:02:31Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/ForwardCommonData
SimDataFormats/CaloTest
SimG4CMS/Forward

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-06-15T21:11:49Z

+1
Tested at: 94882b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19258/20617/summary.html

cmsbuild · 2017-06-15T21:11:53Z

Comparison job queued.

cmsbuild · 2017-06-15T21:58:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19258/20617/summary.html

Comparison Summary:

You potentially added 3 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1803204
DQMHistoTests: Total failures: 95
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1802943
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

ianna · 2017-06-19T15:07:21Z

SimG4CMS/Forward/test/SimG4FluxAnalyzer.cc

+  std::vector<edm::EDGetTokenT<ParticleFlux> > tok_PF_;
+  TTree                                       *tree_;
+
+  std::vector<std::string>                     detName;


@bsunanda - please, use consistent naming convention: trailing underscore for private variables

ianna · 2017-06-19T15:09:21Z

SimDataFormats/CaloTest/src/classes.h

 #include "DataFormats/Common/interface/Wrapper.h"

 namespace SimDataFormats_CaloTest {
  struct dictionary {
    HcalTestHistoClass theHcalTestHistoClass;
+    ParticleFlux                                         d1;


@bsunanda - please, use consistent naming convention for private variables: e.g. trailing underscore or leading "m_"

bsunanda · 2017-06-21T09:45:12Z

@cmsbuild Please test

cmsbuild · 2017-06-21T09:45:16Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20808/console Started: 2017/06/21 11:47

cmsbuild · 2017-06-21T09:45:18Z

Pull request #19258 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

smuzaffar · 2017-06-22T08:28:23Z

this is fixed for today's IBs. we need to re-run PR tests once next IB is available.

smuzaffar · 2017-06-22T09:29:50Z

please test

cmsbuild · 2017-06-22T09:30:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20836/console Started: 2017/06/22 11:31

cmsbuild · 2017-06-22T10:56:47Z

+1
Tested at: 8f6332e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19258/20836/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4bfcf97
1c5bd71
8730b28
259c301
4e50f86
d0a212b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19258/20836/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19258/20836/git-merge-result

cmsbuild · 2017-06-22T10:56:50Z

Comparison job queued.

cmsbuild · 2017-06-22T13:43:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19258/20836/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1802916
DQMHistoTests: Total failures: 44267
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1758483
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

ianna · 2017-06-22T14:22:05Z

+1

civanch · 2017-06-22T16:11:27Z

+1

cmsbuild · 2017-06-22T16:11:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

bsunanda · 2017-06-23T11:48:59Z

@davidlange6 Please merge this

davidlange6 · 2017-06-25T13:33:51Z

+1

Record particle flux in selected volumes

94882b0

cmsbuild added this to the CMSSW_9_2_X milestone Jun 15, 2017

cmsbuild added comparison-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending labels Jun 15, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 15, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 15, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 15, 2017

ianna suggested changes Jun 19, 2017

View reviewed changes

Following coding rules

b46156d

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jun 21, 2017

cmsbuild removed the tests-pending label Jun 21, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 22, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 22, 2017

cmsbuild added geometry-approved and removed geometry-pending labels Jun 22, 2017

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jun 22, 2017

cmsbuild added orp-approved and removed orp-pending labels Jun 25, 2017

cmsbuild merged commit 1e2e6eb into cms-sw:master Jun 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run2-sim09 Record particle flux in selected volumes #19258

Run2-sim09 Record particle flux in selected volumes #19258

bsunanda commented Jun 15, 2017

bsunanda commented Jun 15, 2017

cmsbuild commented Jun 15, 2017 •

edited

cmsbuild commented Jun 15, 2017

cmsbuild commented Jun 15, 2017

cmsbuild commented Jun 15, 2017

cmsbuild commented Jun 15, 2017

ianna Jun 19, 2017

bsunanda Jun 21, 2017

ianna Jun 19, 2017

bsunanda Jun 21, 2017

bsunanda commented Jun 21, 2017

cmsbuild commented Jun 21, 2017 •

edited

cmsbuild commented Jun 21, 2017

smuzaffar commented Jun 22, 2017

smuzaffar commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 •

edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

ianna commented Jun 22, 2017

civanch commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

bsunanda commented Jun 23, 2017

davidlange6 commented Jun 25, 2017

Run2-sim09 Record particle flux in selected volumes #19258

Run2-sim09 Record particle flux in selected volumes #19258

Conversation

bsunanda commented Jun 15, 2017

bsunanda commented Jun 15, 2017

cmsbuild commented Jun 15, 2017 • edited

cmsbuild commented Jun 15, 2017

cmsbuild commented Jun 15, 2017

cmsbuild commented Jun 15, 2017

cmsbuild commented Jun 15, 2017

ianna Jun 19, 2017

Choose a reason for hiding this comment

bsunanda Jun 21, 2017

Choose a reason for hiding this comment

ianna Jun 19, 2017

Choose a reason for hiding this comment

bsunanda Jun 21, 2017

Choose a reason for hiding this comment

bsunanda commented Jun 21, 2017

cmsbuild commented Jun 21, 2017 • edited

cmsbuild commented Jun 21, 2017

smuzaffar commented Jun 22, 2017

smuzaffar commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 • edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

ianna commented Jun 22, 2017

civanch commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

bsunanda commented Jun 23, 2017

davidlange6 commented Jun 25, 2017

cmsbuild commented Jun 15, 2017 •

edited

cmsbuild commented Jun 21, 2017 •

edited

cmsbuild commented Jun 22, 2017 •

edited