Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialise variables in FastMonitoringService #19271

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 16, 2017

Running offline a configuration with the FastMonitoringService I get a segmentation fault near th beginning of the job.

Initialising these variables cures the issue, and let the job run successfully.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 16, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

EventFilter/Utilities

@perrotta, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20661/console Started: 2017/06/17 00:26

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19271/20661/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803204
  • DQMHistoTests: Total failures: 29394
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1773644
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@mommsen
Copy link
Contributor

mommsen commented Jun 17, 2017

+1

@slava77
Copy link
Contributor

slava77 commented Jun 17, 2017

+1

for #19271 d50e55d

  • technical
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 17, 2017 via email

@cmsbuild cmsbuild merged commit b8b2b04 into cms-sw:master Jun 17, 2017
@fwyzard fwyzard deleted the FastMonitoringService_initialise_atomic_variables branch July 11, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants