Fix includes in SingleElementCollectionRefSelector headers #19287
Conversation
|
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
Teemperor
force-pushed
the
FixIncludesSingleElementCollectionRefSelector.h
branch
2 times, most recently
from
57d3e21
to
da236e1
Compare
Teemperor
changed the title
Teemperor
force-pushed
the
FixIncludesSingleElementCollectionRefSelector.h
branch
from
da236e1
to
f63662b
Compare
We use SelectedOutputCollectionTrait in these header, so we also need to include the related header to make these file compile on its own. Same goes for Event and EventSetup, but in this case we can just forward declare them.
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: CommonTools/UtilAlgos @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
Teemperor
deleted the
FixIncludesSingleElementCollectionRefSelector.h
branch
Teemperor
restored the
FixIncludesSingleElementCollectionRefSelector.h
branch
We use SelectedOutputCollectionTrait in these headers, so we also
need to include the related header to make these file compile
on its own.
Same goes for Event and EventSetup, but in this case we can just
forward declare them.