New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix includes of ESDaqInfoTask.h #19295
Conversation
We need to include ESElectronicsMapper.h because we access the ESElectronicsMapper in the `getFedNumber` method of this file. We also forward declare DQMStore and MonitorElement because we have pointers to those classes as member variables.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: DQM/EcalPreshowerMonitorModule @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
We need to include ESElectronicsMapper.h because we access the
ESElectronicsMapper in the
getFedNumber
method of this file.We also forward declare DQMStore and MonitorElement because we
have pointers to those classes as member variables.