New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CompareTwoInstances.hh #19298
Remove CompareTwoInstances.hh #19298
Conversation
This file hasn't been modified in years and also can't be parsed because it has a stray "/" in it that was supposed to be a line comment, so I think we can remove it.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: DQM/L1TMonitor @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
// initialize in the constructor | ||
// Coll1_ = iConfig.getUntrackedParameter<edm::InputTag>("Coll1"); | ||
// Coll2_ = iConfig.getUntrackedParameter<edm::InputTag>("Coll2"); | ||
/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to point out the stray /
Please test |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
merge
On 16 Jun 2017, at 17:09, Raphael Isemann <notifications@github.com<mailto:notifications@github.com>> wrote:
This file hasn't been modified in years and also can't be parsed
because it has a stray "/" in it that was supposed to be a line
comment, so I think we can remove it.
…________________________________
You can view, comment on, or merge this pull request online at:
#19298
Commit Summary
* Remove CompareTwoInstances.hh
File Changes
* D DQM/L1TMonitor/interface/CompareTwoInstances.hh<https://github.com/cms-sw/cmssw/pull/19298/files#diff-0> (115)
Patch Links:
* https://github.com/cms-sw/cmssw/pull/19298.patch
* https://github.com/cms-sw/cmssw/pull/19298.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#19298>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw433dGCCag5eyal2InGhP9fIrvYdks5sEppugaJpZM4N8lCh>.
|
Comparison is ready Comparison Summary:
|
This file hasn't been modified in years and also can't be parsed
because it has a stray "/" in it that was supposed to be a line
comment, so I think we can remove it.