Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CompareTwoInstances.hh #19298

Merged
merged 1 commit into from Jun 17, 2017

Conversation

Teemperor
Copy link
Contributor

This file hasn't been modified in years and also can't be parsed
because it has a stray "/" in it that was supposed to be a line
comment, so I think we can remove it.

This file hasn't been modified in years and also can't be parsed
because it has a stray "/" in it that was supposed to be a line
comment, so I think we can remove it.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@kreczko, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

// initialize in the constructor
// Coll1_ = iConfig.getUntrackedParameter<edm::InputTag>("Coll1");
// Coll2_ = iConfig.getUntrackedParameter<edm::InputTag>("Coll2");
/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to point out the stray /

@davidlange6
Copy link
Contributor

Please test

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20663/console Started: 2017/06/17 10:53

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 17, 2017 via email

@cmsbuild cmsbuild merged commit ab231c2 into cms-sw:master Jun 17, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19298/20663/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803136
  • DQMHistoTests: Total failures: 15118
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1787852
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@Teemperor Teemperor deleted the RemoveCompareTwoInstances.hh branch December 19, 2017 08:47
@Teemperor Teemperor restored the RemoveCompareTwoInstances.hh branch December 19, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants