New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::shared_ptr in FastMonitoringThread.h #19330
Conversation
We don't include boost/shared_ptr in this header, so this header doesn't compile on its own right now. Instead of include the boost header, let's just move to std::shared_ptr instead as this is anyway just a private member variable.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: EventFilter/Utilities @perrotta, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
We don't include boost/shared_ptr in this header, so this header
doesn't compile on its own right now. Instead of include the
boost header, let's just move to std::shared_ptr instead as this
is anyway just a private member variable.