New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix includes in RecoEcal/EgammaClusterProducers #19364
Fix includes in RecoEcal/EgammaClusterProducers #19364
Conversation
This patch makes the headers parsable on their own by adding the necessary includes to resolve all referenced types. It adds an include to: * SuperClusterFwd.h for the class SuperClusterCollection * Point3D.h for the class math::XZYPoint * EcalRecHitCollections.h for the class EcalRecHitCollection * BasicClusterFwd.h for the class BasicClusterCollection
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: RecoEcal/EgammaClusterProducers @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
merge |
This patch makes the headers parsable on their own by adding
the necessary includes to resolve all referenced types.
It adds an include to: