Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includes in RecoEcal/EgammaClusterProducers #19364

Merged

Conversation

Teemperor
Copy link
Contributor

This patch makes the headers parsable on their own by adding
the necessary includes to resolve all referenced types.

It adds an include to:

  • SuperClusterFwd.h for the class SuperClusterCollection
  • Point3D.h for the class math::XZYPoint
  • EcalRecHitCollections.h for the class EcalRecHitCollection
  • BasicClusterFwd.h for the class BasicClusterCollection

This patch makes the headers parsable on their own by adding
the necessary includes to resolve all referenced types.

It adds an include to:
* SuperClusterFwd.h for the class SuperClusterCollection
* Point3D.h for the class math::XZYPoint
* EcalRecHitCollections.h for the class EcalRecHitCollection
* BasicClusterFwd.h for the class BasicClusterCollection
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

RecoEcal/EgammaClusterProducers

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @rafaellopesdesa, @lgray this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 19, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20742/console Started: 2017/06/19 18:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19364/20742/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803204
  • DQMHistoTests: Total failures: 29874
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1773164
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 20, 2017

+1

for #19364 ae4074b

  • technical
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b351cba into cms-sw:master Jun 20, 2017
@Teemperor Teemperor deleted the FixIncludesRecoEcalEgammaClusterProducers branch December 19, 2017 08:47
@Teemperor Teemperor restored the FixIncludesRecoEcalEgammaClusterProducers branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants