Remove BasicFilter.h

[Teemperor]

This file tries to define a "vitrual"[sic] function and wasn't
touched in years, so I think we can remove this.

[Teemperor]

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

[cmsbuild]

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

PhysicsTools/UtilAlgos

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20780/console Started: 2017/06/20 13:41

[slava77]

git grep -w -l BasicFilter
PhysicsTools/UtilAlgos/interface/BasicFilter.h
PhysicsTools/UtilAlgos/interface/EDFilterObjectWrapper.h
PhysicsTools/UtilAlgos/interface/EDFilterWrapper.h

This file BasicFilter is provided as a skeleton.
If there are compilation problems with it, it would be better to fix them.
Otherwise, some relevant changes need to be made in EDFilterObjectWrapper.h and EDFilterWrapper.h to contain appropriate documentation how to get a skeleton code

[cmsbuild]

+1
Tested at: 227430f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19381/20780/summary.html

[cmsbuild]

Comparison job queued.

[davidlange6]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19381/20780/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1803226
• DQMHistoTests: Total failures: 29842
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1773218
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[Teemperor]

Seems like this got already merged (sorry, hard to keep track with all the cmsbuild notifications). @slava77 Shall I make a new PR where I readd this file with the typo fixed?

[davidlange6]

sorry I missed @slava77 comment.

however EDFilter(Object)Wrapper do not directly use BasicFilter. So i don't see the relevance.
It looks like at some point in history there was a BasicMuonFilter (still referenced by BasicFilter!), but its gone. Looks like obsolete stuff to me.

[slava77]

as I said, I interpreted BasicFilter as a skeleton example.
This pattern may often not have a compiled code.

Perhaps I'm wrong and the other two files just have outdated edits referring to BasicFilter.
It would help to scrub mentions like this when files are removed.
(git grep should return no hits before git rm)