Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bitObj.h #19382

Merged
merged 1 commit into from Jun 21, 2017
Merged

Remove bitObj.h #19382

merged 1 commit into from Jun 21, 2017

Conversation

Teemperor
Copy link
Contributor

'bitset m_a' is not really C++ from my understanding.

'bitset<int N> m_a' it not really C++ from my understanding.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

CondFormats/Calibration

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20781/console Started: 2017/06/20 13:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19382/20781/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803260
  • DQMHistoTests: Total failures: 15016
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1788078
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 20, 2017

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 0939068 into cms-sw:master Jun 21, 2017
@Teemperor Teemperor deleted the RemovebitObj.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the RemovebitObj.h branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants