Disable the triggerCache in the multithreaded environment. #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_0_THREADED_X. Disable the triggerCache in the multithreaded environment. It involves the following packages: IOPool/Input @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
ktf
added a commit
that referenced
this pull request
Jan 3, 2014
Multithreading fixes -- Disable the triggerCache in the multithreaded environment.
ggovi
pushed a commit
to ggovi/cmssw
that referenced
this pull request
Jan 11, 2017
Updated root to tip of v6-02-00-patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two separate caches used by PoolSource for reading events in input files. The secondary one, called the trigger cache, is used only in unusual circumstances. However, in the multithreaded environment, having the trigger cache enabled can cause occasional fatal asserts due to a yet undiscovered bug in its implementation. Since there is doubt that the trigger cache is useful in a multithreaded environment, this pull request simply disables it for now. This eliminates the asserts.