Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[92x] EcalPedestal PCL workflow: fixes and improvements #19412

Merged
merged 7 commits into from Jun 25, 2017

Conversation

cerminar
Copy link
Contributor

This PR addresses some issues of this new PCL workflow. It would be useful to have this integrated to complete tests @ tier0

  • fix RAW output module in TestEnable AlcaRAW scenario
  • fix ALCAPROMPT data-tier in alcaskimming
  • add the needed metadata for the GUI to the DQM file produced by the workflow
  • decouple RAW production from actual PCL processing (should be safer for the RAW)
  • change the relval workflow 1010 accordingly

@cerminar
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Jun 23, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20869/console Started: 2017/06/23 11:10

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerminar for master.

It involves the following packages:

Calibration/EcalAlCaRecoProducers
Calibration/EcalCalibAlgos
Configuration/DataProcessing
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@ghellwig, @kkousour, @arunhep, @cerminar, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @argiro, @Martin-Grunewald, @rovere, @ebrondol, @VinInn, @mmusich, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@arunhep
Copy link
Contributor

arunhep commented Jun 23, 2017

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19412/20869/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1802882
  • DQMHistoTests: Total failures: 14916
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1787800
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor

+1

@fabozzi
Copy link
Contributor

fabozzi commented Jun 23, 2017

+1

@davidlange6
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants