Run2-alca81 Modify and reallocate the scripts used for calibration #19413

bsunanda · 2017-06-23T11:35:12Z

Some of the scripts need modification in view of recent changes in IsoTrack calibration procedure

cmsbuild · 2017-06-23T11:35:34Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos
Calibration/IsolatedParticles

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2017-06-23T11:36:15Z

@cmsbuild Please test

cmsbuild · 2017-06-23T11:36:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20876/console Started: 2017/06/23 14:25

cmsbuild · 2017-06-23T13:08:00Z

+1
Tested at: b18e717
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20876/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5ad2ca3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20876/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20876/git-merge-result

cmsbuild · 2017-06-23T13:08:04Z

Comparison job queued.

cmsbuild · 2017-06-23T13:44:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20876/summary.html

Comparison Summary:

You potentially added 5 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1802882
DQMHistoTests: Total failures: 96
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1802620
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

bsunanda · 2017-06-23T13:53:03Z

@arunhep Can you approve this?

arunhep · 2017-06-23T14:03:54Z

+1

cmsbuild · 2017-06-23T14:04:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-06-24T11:54:34Z

Calibration/HcalCalibAlgos/macros/CalibFitPlots.C

+  double LowEdge  = mean - 1.5*rms;
+  double HighEdge = mean + 2.0*rms;
+  if (LowEdge < 0.15) LowEdge = 0.15;
+  char option[20];


hi @bsunanda - please use a std::string here.

smuzaffar · 2017-06-25T08:11:55Z

please test

cmsbuild · 2017-06-25T08:12:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20905/console Started: 2017/06/25 11:14

cmsbuild · 2017-06-25T10:10:25Z

+1
Tested at: 6c78500
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20905/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9a76fc2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20905/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20905/git-merge-result

cmsbuild · 2017-06-25T10:10:28Z

Comparison job queued.

cmsbuild · 2017-06-25T14:46:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19413/20905/summary.html

Comparison Summary:

You potentially added 2 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1799539
DQMHistoTests: Total failures: 29447
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1769926
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

arunhep · 2017-06-30T08:37:52Z

+1

cmsbuild · 2017-06-30T08:38:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

Modify and reallocate the scripts used for calibration

b18e717

cmsbuild added this to the CMSSW_9_2_X milestone Jun 23, 2017

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures tests-pending labels Jun 23, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 23, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 23, 2017

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 23, 2017

davidlange6 reviewed Jun 24, 2017

View reviewed changes

changed char to string

6c78500

cmsbuild removed alca-approved comparison-available labels Jun 24, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 24, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 25, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 25, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 25, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 25, 2017

smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 30, 2017

davidlange6 merged commit 90c0e42 into cms-sw:master Jun 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run2-alca81 Modify and reallocate the scripts used for calibration #19413

Run2-alca81 Modify and reallocate the scripts used for calibration #19413

bsunanda commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

bsunanda commented Jun 23, 2017

cmsbuild commented Jun 23, 2017 •

edited

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

bsunanda commented Jun 23, 2017

arunhep commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 Jun 24, 2017

smuzaffar commented Jun 25, 2017

cmsbuild commented Jun 25, 2017 •

edited

cmsbuild commented Jun 25, 2017

cmsbuild commented Jun 25, 2017

cmsbuild commented Jun 25, 2017

arunhep commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

Run2-alca81 Modify and reallocate the scripts used for calibration #19413

Run2-alca81 Modify and reallocate the scripts used for calibration #19413

Conversation

bsunanda commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

bsunanda commented Jun 23, 2017

cmsbuild commented Jun 23, 2017 • edited

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

bsunanda commented Jun 23, 2017

arunhep commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 Jun 24, 2017

Choose a reason for hiding this comment

smuzaffar commented Jun 25, 2017

cmsbuild commented Jun 25, 2017 • edited

cmsbuild commented Jun 25, 2017

cmsbuild commented Jun 25, 2017

cmsbuild commented Jun 25, 2017

arunhep commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

cmsbuild commented Jun 23, 2017 •

edited

cmsbuild commented Jun 25, 2017 •

edited