Run2-TB32 Add simulation for the Timing layer TB studies #19419

bsunanda · 2017-06-23T16:25:00Z

No description provided.

bsunanda · 2017-06-23T16:25:17Z

cmsbuild · 2017-06-23T16:25:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20893/console Started: 2017/06/23 18:26

cmsbuild · 2017-06-23T16:25:22Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
SimG4CMS/Calo
SimG4CMS/HGCalTestBeam
SimG4Core/Application

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-06-23T18:40:03Z

+1
Tested at: 61e42f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/20893/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5ad2ca3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/20893/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/20893/git-merge-result

cmsbuild · 2017-06-23T18:40:07Z

Comparison job queued.

cmsbuild · 2017-06-23T20:51:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/20893/summary.html

Comparison Summary:

You potentially added 5 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1802916
DQMHistoTests: Total failures: 14923
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1787827
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

ianna · 2017-06-26T07:09:40Z

+1

civanch · 2017-06-26T07:50:11Z

+1

kpedro88 · 2017-06-26T18:53:36Z

SimG4CMS/HGCalTestBeam/plugins/HGCalTiminAnalyzer.cc

@@ -0,0 +1,350 @@
+// system include files


please fix the name of this file (Timin -> Timing)

kpedro88 · 2017-06-26T18:55:02Z

SimG4CMS/HGCalTestBeam/plugins/HGCalTiminAnalyzer.cc

+  } else { 
+    const HepMC::GenEvent * myGenEvent = evtMC->GetEvent();
+    unsigned int k(0);
+    for (HepMC::GenEvent::particle_const_iterator p = myGenEvent->particles_begin();


If this loop only exists to print debug information, the entire loop can be put inside the EDM_ML_DEBUG flag (actually, it looks like everything in this else block can be)

It is left for future development. We leave this code within the EDM_ML_DEBUG for the time being

kpedro88 · 2017-06-26T18:56:17Z

SimG4CMS/HGCalTestBeam/plugins/HGCalTiminAnalyzer.cc

+
+void HGCalTimingAnalyzer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
+  edm::ParameterSetDescription desc;
+  desc.setUnknown();


remove this line (the desc is not unknown)

kpedro88 · 2017-06-26T18:57:21Z

SimG4CMS/HGCalTestBeam/plugins/HGCalTiminAnalyzer.cc

+  detectorBeam_= iConfig.getParameter<std::string>("DetectorBeam");
+  groupHits_   = iConfig.getParameter<bool>("GroupHits");
+  timeUnit_    = iConfig.getParameter<double>("TimeUnit");
+  idBeams_     = iConfig.getParameter<std::vector<int>>("IDBeams");  


what is this parameter used for?

Try to add comment

cmsbuild · 2017-06-29T15:54:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21002/console Started: 2017/06/29 17:55

cmsbuild · 2017-06-29T15:54:47Z

Pull request #19419 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

cmsbuild · 2017-06-29T17:06:41Z

+1
Tested at: 615e563
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/21002/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1974578
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/21002/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/21002/git-merge-result

cmsbuild · 2017-06-29T17:06:44Z

Comparison job queued.

cmsbuild · 2017-06-29T18:59:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19419/21002/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19419/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17
/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19419/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19

Comparison Summary:

You potentially added 3 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 15028
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1740869
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

kpedro88 · 2017-06-30T13:37:01Z

+1

ianna · 2017-06-30T14:41:19Z

+1

bsunanda · 2017-07-03T13:19:41Z

@civanch Could you approve this again?
@davidlange6 Please integrate this

civanch · 2017-07-03T13:24:25Z

+1

cmsbuild · 2017-07-03T13:24:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-04T10:28:36Z

merge

Add simulation for the Timing layer TB studies

61e42f9

cmsbuild added this to the CMSSW_9_2_X milestone Jun 23, 2017

cmsbuild added comparison-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Jun 23, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 23, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 23, 2017

cmsbuild added geometry-approved and removed geometry-pending labels Jun 26, 2017

cmsbuild added simulation-approved and removed simulation-pending labels Jun 26, 2017

smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017

kpedro88 reviewed Jun 26, 2017

View reviewed changes

cmsbuild added pending-signatures simulation-pending tests-pending upgrade-pending labels Jun 29, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 29, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 29, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 29, 2017

cmsbuild added upgrade-approved and removed upgrade-pending labels Jun 30, 2017

cmsbuild added geometry-approved and removed geometry-pending labels Jun 30, 2017

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jul 3, 2017

cmsbuild merged commit db12bb5 into cms-sw:master Jul 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run2-TB32 Add simulation for the Timing layer TB studies #19419

Run2-TB32 Add simulation for the Timing layer TB studies #19419

bsunanda commented Jun 23, 2017

bsunanda commented Jun 23, 2017

cmsbuild commented Jun 23, 2017 •

edited

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

ianna commented Jun 26, 2017

civanch commented Jun 26, 2017

kpedro88 Jun 26, 2017

bsunanda Jun 26, 2017

kpedro88 Jun 26, 2017

bsunanda Jun 26, 2017

kpedro88 Jun 26, 2017

bsunanda Jun 26, 2017

kpedro88 Jun 26, 2017

bsunanda Jun 26, 2017

cmsbuild commented Jun 29, 2017 •

edited

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

kpedro88 commented Jun 30, 2017

ianna commented Jun 30, 2017

bsunanda commented Jul 3, 2017

civanch commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

davidlange6 commented Jul 4, 2017

Run2-TB32 Add simulation for the Timing layer TB studies #19419

Run2-TB32 Add simulation for the Timing layer TB studies #19419

Conversation

bsunanda commented Jun 23, 2017

bsunanda commented Jun 23, 2017

cmsbuild commented Jun 23, 2017 • edited

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

ianna commented Jun 26, 2017

civanch commented Jun 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Jun 29, 2017 • edited

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

kpedro88 commented Jun 30, 2017

ianna commented Jun 30, 2017

bsunanda commented Jul 3, 2017

civanch commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

davidlange6 commented Jul 4, 2017

cmsbuild commented Jun 23, 2017 •

edited

cmsbuild commented Jun 29, 2017 •

edited