70x improve unittest for fireworks configuration #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unit-test -- the existance of non-empty file is checked at the parsing of cmsShow arguments.
|
A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_0_X. 70x improve unittest for fireworks configuration It involves the following packages: Fireworks/Core @Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
|
+1 |
ktf
added a commit
that referenced
this pull request
Jan 7, 2014
Fireworks fixes -- 70x improve unittest for fireworks configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CmsShow checks for existence of non-empty configuration file at the time of parsing its arguments. Therefore this check does not make sense.
Add new check for configuration file parse errors.