Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr92/93x L1T allow correlations from other than bx=0 #19453

Merged
merged 1 commit into from Jun 28, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jun 27, 2017

pr93x L1T

Update correlation routines to get kinematics from objects other than bx=0

Then will want to make patch to 924.
(same branch can be used )

@rekovic
Copy link
Contributor Author

rekovic commented Jun 27, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20957/console Started: 2017/06/27 20:20

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19453/20957/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1754263
  • DQMHistoTests: Total failures: 15022
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1739075
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Jun 28, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5137719 into cms-sw:master Jun 28, 2017
cmsbuild added a commit that referenced this pull request Jul 6, 2017
pr92/93x L1T allow correlations from other than bx=0 (backport of #19453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants