Update dimuon L3 filter, for 2017 online muon reconstruction #19466

BenjaminRS · 2017-06-28T18:05:06Z

This PR complements that of #19465 for the dimuon L3 filter counterpart. It allows to:

handle muons reconstructed by the full (L3FromL2 + L3FromL1) iterL3 sequence, and perform the matching with the candidate from the previous step
introduce the possibility of disabling the matching of the L3 to the previous candidate (L2 or L1)

…nd a muon from L3FromL1

cmsbuild · 2017-06-28T18:05:23Z

A new Pull Request was created by @BenjaminRS (Benjamin Radburn-Smith) for master.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2017-06-28T18:09:22Z

HLTrigger/Muon/src/HLTMuonDimuonL3Filter.cc

+
+bool HLTMuonDimuonL3Filter::applyMuonSelection(const RecoChargedCandidateRef& cand, const BeamSpot& beamSpot) const{
+	// eta cut
+	if (fabs(cand->eta())>max_Eta_) return false;


can you use std::abs instead ?

Martin-Grunewald · 2017-06-29T10:51:57Z

Presumably we need a PR for 92X as well - please make one!

cmsbuild · 2017-06-29T11:45:34Z

Pull request #19466 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

Martin-Grunewald · 2017-06-29T11:53:10Z

please test

cmsbuild · 2017-06-29T11:53:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20983/console Started: 2017/06/29 15:39

cmsbuild · 2017-06-29T14:46:56Z

+1
Tested at: 4e66840
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/20983/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1974578
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/20983/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/20983/git-merge-result

cmsbuild · 2017-06-29T14:46:59Z

Comparison job queued.

cmsbuild · 2017-06-29T16:07:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/20983/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19466/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17
/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19466/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19

Comparison Summary:

You potentially added 3 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 95
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1755802
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

Martin-Grunewald · 2017-07-03T07:35:25Z

+1

cmsbuild · 2017-07-04T18:35:54Z

Pull request #19466 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

Martin-Grunewald · 2017-07-05T04:55:32Z

please test

cmsbuild · 2017-07-05T04:55:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21161/console Started: 2017/07/05 09:29

cmsbuild · 2017-07-05T08:31:06Z

+1
Tested at: 2d36a4c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/21161/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
63024c6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/21161/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/21161/git-merge-result

cmsbuild · 2017-07-05T08:31:09Z

Comparison job queued.

cmsbuild · 2017-07-05T10:41:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19466/21161/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1785410
DQMHistoTests: Total failures: 29851
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1755393
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

Martin-Grunewald · 2017-07-05T10:59:03Z

+1

cmsbuild · 2017-07-05T10:59:20Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-05T11:18:09Z

+1

BenjaminRS added 2 commits June 26, 2017 13:38

Updating the DimuonL3Filters for full iterL3

a59a68e

Adding possibility to have a dimuon made using a muon from L3FromL2 a…

89852ae

…nd a muon from L3FromL1

cmsbuild added this to the CMSSW_9_3_X milestone Jun 28, 2017

cmsbuild added comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels Jun 28, 2017

fwyzard reviewed Jun 28, 2017

View reviewed changes

Updating after Andrea's comments: std::abs and l1CandTag_ label

4e66840

cmsbuild added tests-started and removed tests-pending labels Jun 29, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 29, 2017

BenjaminRS mentioned this pull request Jun 29, 2017

Update dimuon L3 filter, for 2017 online muon reconstruction. 92X Version #19484

Merged

cmsbuild added comparison-available and removed comparison-pending labels Jun 29, 2017

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Jul 3, 2017

cmsbuild added comparison-pending hlt-pending pending-signatures tests-pending and removed comparison-available fully-signed hlt-approved tests-approved labels Jul 4, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 5, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 5, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 5, 2017

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Jul 5, 2017

cmsbuild added orp-approved and removed orp-pending labels Jul 5, 2017

cmsbuild merged commit 1380347 into cms-sw:master Jul 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dimuon L3 filter, for 2017 online muon reconstruction #19466

Update dimuon L3 filter, for 2017 online muon reconstruction #19466

BenjaminRS commented Jun 28, 2017

cmsbuild commented Jun 28, 2017

fwyzard Jun 28, 2017

Martin-Grunewald commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

Martin-Grunewald commented Jun 29, 2017

cmsbuild commented Jun 29, 2017 •

edited

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

Martin-Grunewald commented Jul 3, 2017

cmsbuild commented Jul 4, 2017

Martin-Grunewald commented Jul 5, 2017

cmsbuild commented Jul 5, 2017 •

edited

cmsbuild commented Jul 5, 2017

cmsbuild commented Jul 5, 2017

cmsbuild commented Jul 5, 2017

Martin-Grunewald commented Jul 5, 2017

cmsbuild commented Jul 5, 2017

davidlange6 commented Jul 5, 2017

Update dimuon L3 filter, for 2017 online muon reconstruction #19466

Update dimuon L3 filter, for 2017 online muon reconstruction #19466

Conversation

BenjaminRS commented Jun 28, 2017

cmsbuild commented Jun 28, 2017

fwyzard Jun 28, 2017

Choose a reason for hiding this comment

Martin-Grunewald commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

Martin-Grunewald commented Jun 29, 2017

cmsbuild commented Jun 29, 2017 • edited

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

Martin-Grunewald commented Jul 3, 2017

cmsbuild commented Jul 4, 2017

Martin-Grunewald commented Jul 5, 2017

cmsbuild commented Jul 5, 2017 • edited

cmsbuild commented Jul 5, 2017

cmsbuild commented Jul 5, 2017

cmsbuild commented Jul 5, 2017

Martin-Grunewald commented Jul 5, 2017

cmsbuild commented Jul 5, 2017

davidlange6 commented Jul 5, 2017

cmsbuild commented Jun 29, 2017 •

edited

cmsbuild commented Jul 5, 2017 •

edited