Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to load dictionary for class #1947

Merged
merged 1 commit into from Jan 4, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 4, 2014

This is a ROOT6 specific bug fix that allows two more framework unit tests to pass.
If an attempt is made to construct a TypeWithDict from a class name, and the dictionary for the class has not yet been loaded, a default TypeWithDict is constructed, rather than one for the class in question.
The fix calls TClass::GetClass for the class name, which will load the dictionary if RootAutoLibraryLoader is in use.
Then, the proper TypeWithDict can be constructed instead of a default one.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2014

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

Attempt to load dictionary for class

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Jan 4, 2014
ROOT6 -- Attempt to load dictionary for class
@ktf ktf merged commit 1c4139f into cms-sw:CMSSW_7_0_ROOT6_X Jan 4, 2014
@wmtan wmtan deleted the LoadDictionaryIfNotYetLoaded branch January 7, 2014 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants