Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swith to 2017 vtx smearing for HI wfs #19475

Merged
merged 1 commit into from Jul 2, 2017

Conversation

mandrenguyen
Copy link
Contributor

Currently using old Run 2 vertex smearing, which is no longer consistent with the pp phase 1 GTs.
We will eventually migrate to a dedicated HI vtx smearing and beamspot, but for the time being we want to stay in sync with the current detector and data taking conditions.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

Configuration/PyReleaseValidation

@kkousour, @kpedro88, @fabozzi, @cmsbuild, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor

fabozzi commented Jun 29, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 29, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20985/console Started: 2017/06/29 15:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Jun 29, 2017

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19475/20985/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19475/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17
  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19475/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756063
  • DQMHistoTests: Total failures: 14511
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1741386
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d45cdf into cms-sw:master Jul 2, 2017
mandrenguyen added a commit to mandrenguyen/cmssw that referenced this pull request Sep 27, 2017
@mandrenguyen mandrenguyen deleted the vtxSmearing2017forHI branch March 4, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants