Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebinning ADC Phase 1 #19476

Merged
merged 1 commit into from Jul 6, 2017
Merged

Rebinning ADC Phase 1 #19476

merged 1 commit into from Jul 6, 2017

Conversation

fioriNTU
Copy link
Contributor

This PR reduce by a factor of 8 the bins in ADC distributions
Also the range of few histograms of number of digis and clusters is adjusted (no difference in the binning)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Digis

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@boudoul
Copy link
Contributor

boudoul commented Jul 3, 2017

Hi @dmitrijus , could you please consider this PR ? thanks

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21201/console Started: 2017/07/06 09:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison job queued.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5a77c2d into cms-sw:master Jul 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19476/21201/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1787242
  • DQMHistoTests: Total failures: 14558
  • DQMHistoTests: Total nulls: 5701
  • DQMHistoTests: Total successes: 1766817
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants