Phase2-hgx87 Add functionality in geometry to enable avoid magic # usage in reconstruction #19485
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HGCalCommonData @perrotta, @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
| @@ -73,6 +73,9 @@ class HGCalDDDConstants { | |||
| int& wafer, int& icell, | |||
| int& celltyp) const; | |||
| bool waferInLayer(int wafer, int lay, bool reco) const; | |||
| int waferKount(const int type) const {return ((type == 0) ? waferMax_[2] : waferMax_[3]);} | |||
There was a problem hiding this comment.
misspelling: Kount -> Count
| auto geomFH = static_cast<const HGCalGeometry*>(geom_->getSubdetectorGeometry(DetId::Forward,ForwardSubdetector::HGCHEF)); | ||
| bhOffset_ = fhOffset_ + (geomFH->topology().dddConstants()).layers(true); | ||
| unsigned int wmaxFH = 1 + (geomFH->topology().dddConstants()).waferMax(); | ||
| maxNumberOfWafersPerLayer_ = (wmaxEE > wmaxFH) ? wmaxEE : wmaxFH; |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
alright, thanks, this is useful. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@cmsbuild Please test |
cmsbuild
added
comparison-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Pull request #19485 was updated. @perrotta, @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77, @davidlange6 can you please check and sign again. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
merge |
Only equipped RecTools with some of the stuff - to be propagated to other classes in HGCalRecAlgos