Add CSC and DT segments in miniAOD for highpt muons and enable muon match slimmer #19488

arizzi · 2017-06-29T15:38:18Z

This PR adds DT and CSC segments in miniaod with relinking of the refs in muon matches to the new collection.
The current default is that segments are stored for muons with pt>50 (as the target is exo analyses at high pt).

In addition this PR enables minimal slimming of the muonmatches, this should be cross checked by the muon POG / experts to see if the IDs are stable against this change.

@gpetruc

cmsbuild · 2017-06-29T15:54:35Z

A new Pull Request was created by @arizzi for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

perrotta · 2017-06-29T16:05:28Z

please test

cmsbuild · 2017-06-29T16:05:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21004/console Started: 2017/06/29 18:06

cmsbuild · 2017-06-29T17:56:04Z

+1
Tested at: c39dd08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21004/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1974578
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21004/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21004/git-merge-result

cmsbuild · 2017-06-29T17:56:09Z

Comparison job queued.

cmsbuild · 2017-06-29T20:43:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21004/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19488/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17
/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19488/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19

Comparison Summary:

You potentially added 3 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 14508
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1741389
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

arizzi · 2017-06-30T07:45:05Z

In order to check that the slimming is safe, as suggested by Dima, I checked that pat::Muon::isSoftMuon(...) returns the same value (on 1k events thereare 2230 muons passing the isSoftMuon ID in both cases )

slava77 · 2017-07-01T16:17:20Z

@cmsbuild please test workflow 136.7611,1325.5

cmsbuild · 2017-07-01T16:17:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21052/console Started: 2017/07/01 18:18

slava77 · 2017-07-01T16:18:57Z

@cmsbuild please abort
I forgot that the reminiaod wfs are still broken

cmsbuild · 2017-07-01T16:19:11Z

Jenkins tests are aborted.

slava77 · 2017-07-04T18:14:24Z

@cmsbuild please test workflow 136.7611,1325.5

cmsbuild · 2017-07-04T18:14:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21145/console Started: 2017/07/04 20:15

cmsbuild · 2017-07-04T20:36:02Z

+1
Tested at: c39dd08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21145/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e4d2a49
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21145/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21145/git-merge-result

cmsbuild · 2017-07-04T20:36:06Z

Comparison job queued.

cmsbuild · 2017-07-04T22:56:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19488/21145/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1760883
DQMHistoTests: Total failures: 173
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1760544
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

slava77 · 2017-07-05T16:26:09Z

+1

for #19488 c39dd08

implementation is in line with the description
jenkins tests pass and comparisons show no differences
local tests show expected changes in the data products only in miniAOD: addition of the CSC and DT segments and some reduction in size of the slimmedMuons
- using 3K events in ttbar PU35 (wf 10224) miniAOD processing: there are about 600 and 700 CSC and DT segments, respectively, in the new slimmedMuons segment collection; the event size is up by 50 bytes per event from a reduction of 140 bytes in the muons size and 190 bytes from the segments

arizzi · 2017-07-06T09:04:01Z

@monttj can you please sign?

davidlange6 · 2017-07-07T06:32:08Z

PhysicsTools/PatAlgos/plugins/PATMuonSlimmer.cc

+      std::vector<DTRecSegment4D> outDTSegmentsTmp; 
+      std::map<CSCSegmentRef,size_t> cscMap;
+      std::vector<CSCSegment> outCSCSegmentsTmp; 
+      for(auto & seg : dtSegmentsRefs) {


hi @arizzi - this should be const &, right?

why? the container is a local set of refs ... why should it be const? (I mean, yes it could be const but is kind of irrelevant)

it seems purely cosmetic here.
@arizzi may I ask you to update this.
Thank you.

davidlange6 · 2017-07-17T07:37:38Z

merge

arizzi added 3 commits June 29, 2017 17:34

add DT segments

aaa1434

minor fixes and enable the slimMatches

db72dae

add CSC and configurable selection to only store some segments

c39dd08

arizzi changed the title ~~Add CSC and DT segments in miniAOD for highpt muons and enable muon match slimmers~~ Add CSC and DT segments in miniAOD for highpt muons and enable muon match slimmer Jun 29, 2017

cmsbuild added this to the CMSSW_9_3_X milestone Jun 29, 2017

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 29, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 29, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 29, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 29, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jul 1, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 1, 2017

cmsbuild added tests-pending and removed tests-started labels Jul 1, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 4, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 4, 2017

slava77 mentioned this pull request Jul 5, 2017

HCALDQM: fix RecHitTask crash, adc2fC from DB, fix TPTask, add plots #18841

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 5, 2017

davidlange6 reviewed Jul 7, 2017

View reviewed changes

cmsbuild merged commit b0407e8 into cms-sw:master Jul 17, 2017

arizzi mentioned this pull request Aug 3, 2017

Muon segments in MiniAOD (92X version) #20036

Closed

arizzi deleted the muonSegs branch October 11, 2017 08:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CSC and DT segments in miniAOD for highpt muons and enable muon match slimmer #19488

Add CSC and DT segments in miniAOD for highpt muons and enable muon match slimmer #19488

arizzi commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

perrotta commented Jun 29, 2017

cmsbuild commented Jun 29, 2017 •

edited

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

arizzi commented Jun 30, 2017

slava77 commented Jul 1, 2017

cmsbuild commented Jul 1, 2017 •

edited

slava77 commented Jul 1, 2017

cmsbuild commented Jul 1, 2017

slava77 commented Jul 4, 2017

cmsbuild commented Jul 4, 2017 •

edited

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

slava77 commented Jul 5, 2017

arizzi commented Jul 6, 2017

davidlange6 Jul 7, 2017

arizzi Jul 12, 2017

slava77 Jul 13, 2017

davidlange6 commented Jul 17, 2017

Add CSC and DT segments in miniAOD for highpt muons and enable muon match slimmer #19488

Add CSC and DT segments in miniAOD for highpt muons and enable muon match slimmer #19488

Conversation

arizzi commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

perrotta commented Jun 29, 2017

cmsbuild commented Jun 29, 2017 • edited

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

cmsbuild commented Jun 29, 2017

arizzi commented Jun 30, 2017

slava77 commented Jul 1, 2017

cmsbuild commented Jul 1, 2017 • edited

slava77 commented Jul 1, 2017

cmsbuild commented Jul 1, 2017

slava77 commented Jul 4, 2017

cmsbuild commented Jul 4, 2017 • edited

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

slava77 commented Jul 5, 2017

arizzi commented Jul 6, 2017

davidlange6 Jul 7, 2017

Choose a reason for hiding this comment

arizzi Jul 12, 2017

Choose a reason for hiding this comment

slava77 Jul 13, 2017

Choose a reason for hiding this comment

davidlange6 commented Jul 17, 2017

cmsbuild commented Jun 29, 2017 •

edited

cmsbuild commented Jul 1, 2017 •

edited

cmsbuild commented Jul 4, 2017 •

edited