Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beginning and end of life noise values for BH #19493

Merged
merged 2 commits into from Jul 6, 2017

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jun 30, 2017

New expectations for BH noises values for TDR.
Add end of life configuration for BH (soon to add a new era for this for easy config).

@lgray
Copy link
Contributor Author

lgray commented Jun 30, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21016/console Started: 2017/06/30 09:47

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for master.

It involves the following packages:

SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@cseez, @vandreev11, @sethzenz, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19493/21016/summary.html

Comparison Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 380 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756063
  • DQMHistoTests: Total failures: 29476
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1726421
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Jun 30, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

hi @lgray - could you add a small comment in the cfi to document the source of the new numbers. Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21195/console Started: 2017/07/05 23:35

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Pull request #19493 was updated. @cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19493/21195/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 379 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1786918
  • DQMHistoTests: Total failures: 29359
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1757393
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@civanch
Copy link
Contributor

civanch commented Jul 6, 2017

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 6, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4761895 into cms-sw:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants