Roll back era for early Run 2 heavy-ion relval worflow #19495
Conversation
|
A new Pull Request was created by @mandrenguyen for master. It involves the following packages: Configuration/PyReleaseValidation @kkousour, @kpedro88, @fabozzi, @cmsbuild, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The actual Era used in most of 2015 was Run2_25ns. Is there a specific reason to use 50ns for HI? |
|
@kpedro88 Since we have a long bunch spacing for PbPb, I thought we ran the detectors in 50ns mode. Now that I look back at the original customize though, I see that you're right, we used the 25ns settings. |
|
On 6/30/17 6:51 AM, mandrenguyen wrote:
@kpedro88 <https://github.com/kpedro88> Since we have a long bunch
spacing for PbPb, I thought we ran the detectors in 50ns mode. Now that
I look back at the original customize though, I see that you're right,
we used the 25ns settings.
For reference, see customisePostLS1_HI, here:
https://github.com/cms-sw/cmssw/blob/master/SLHCUpgradeSimulations/Configuration/python/postLS1Customs.py
I will switch that, thanks!
There is a Run2_HI era which is supposed to cover the needs present
earlier in the customisePostLS1_HI
… —
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19495 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbkbBodAl9FkTSO0DhGYY35wc_Tapks5sJP1pgaJpZM4OKk0f>.
|
|
AFAIK it is a sub-era of 2015, ie, need to use: |
|
On 6/30/17 7:10 AM, Martin Grunewald wrote:
AFAIK it is a sub-era of 2015, ie, need to use: |--era=Run2_2015,Run2_HI|
I vaguely recall that when I converted the T0 setup from customise to
eras I have checked
that the Run2_HI (used in
DataProcessing/python/Impl/HeavyIonsEra_Run2_HI.py)
delivers the same as what was used in 75X.
... also, there is no Run2_2015 era
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19495 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbr6E1CcOixsyyE1naU-Qye2qUzxgks5sJQHlgaJpZM4OKk0f>.
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Hmm, ok, in fact what I use is --era=Run2_2016,Run2_HI, but you want 2015, right? |
|
On 6/30/17 7:46 AM, Martin Grunewald wrote:
Hmm, ok, in fact what I use is --era=Run2_2015,Run2_HI, but you want
2015, right?
git grep Run2_2015
produces 0 hits.
I suppose the cmsDriver ignores it and we are back to just Run2_HI
that I think is enough.
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19495 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbmzlWYYctARSR1WYj3c6bmeHv6pVks5sJQpSgaJpZM4OKk0f>.
|
|
--era=Run2_2016,Run2_HI, |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
Only Run2_HI is needed for the era.
|
Pull request #19495 was updated. @kkousour, @kpedro88, @fabozzi, @cmsbuild, @GurpreetSinghChahal, @davidlange6 can you please check and sign again. |
mandrenguyen
changed the title
|
-1 Tested at: c7a34ea The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
Roll back era for early Run 2 heavy-ion relval worflow
As discussed in #19470 the Run 2 heavy-ion reco workflows were migrated to use the Run2_2016 era. Since we didn't use the HI reco in 2016, this doesn't make much sense.
This PR removes Run2_2016 from the era.