Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HLT menu V2.1 - Minotaur (92X) #19503

Merged
merged 10 commits into from Jul 25, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Jul 2, 2017

Update to HLT menu V2.1 - Minotaur (92X)
Based on CMSSW_9_2_7

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2017

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_9_2_X.

It involves the following packages:

Configuration/AlCa
Configuration/HLT
HLTrigger/Configuration
Utilities/ReleaseScripts

@ghellwig, @smuzaffar, @Dr15Jones, @silviodonato, @arunhep, @franzoni, @cerminar, @Martin-Grunewald, @cmsbuild, @fwyzard, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @wddgit, @tocheng, @jalimena, @mmusich, @geoff-smith this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #19502

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21056/console Started: 2017/07/02 06:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2017

-1

Tested at: bb2075b

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1a9d118
f3ec9cc
af675a6
d57a581
88b4d4b
50ad124
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19503/21056/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19503/21056/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19503/21056/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1a9d118
f3ec9cc
af675a6
d57a581
88b4d4b
50ad124
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19503/21056/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19503/21056/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@Martin-Grunewald
Copy link
Contributor Author

Test failures are due to new L1T menu L1Menu_Collisions2017_dev_r6_woCDC_m6_xml needed for the V2 HLT menu in the standard 92X GT keys.

@Martin-Grunewald
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Pull request has been put on hold by @Martin-Grunewald
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@Martin-Grunewald
Copy link
Contributor Author

@arunhep @franzoni @Dr15Jones
please check and sign.

@cmsbuild
Copy link
Contributor

Pull request #19503 was updated. @ghellwig, @smuzaffar, @Dr15Jones, @silviodonato, @arunhep, @franzoni, @cerminar, @Martin-Grunewald, @cmsbuild, @fwyzard, @davidlange6, @lpernie can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21713/console Started: 2017/07/24 17:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19503/21713/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3721 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1763994
  • DQMHistoTests: Total failures: 50831
  • DQMHistoTests: Total nulls: 540
  • DQMHistoTests: Total successes: 1712457
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jul 24, 2017

@Martin-Grunewald
checking wf10024 : 2017 ttbar MC
many changes in different directories which are expected because of change of L1 and HLT menu.
could not understand this directory : https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_2_X_2017-07-24-1100+19503/21523/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/TrackerHitsV_TrackerHit.html
where for some of the distributions, reference had 0 entries and with new menu we got entries like here.
it needs more investigation.
@makortel @fioriNTU can you please help in getting more information about these quantities?

no change in data wf 136.731 as expected.
no change in wf 1001 which is express-like

@franzoni
Copy link

@arunhep

there are indications for the 2017 Full sim that the simhits have changed

(see for instance HCAL and ECAL), a plausible consequence of the changes in GeometryFileRcd/Extended and ( see details of the tag changes between GT's ) which are known to affect the reproducibility of the pseudo-random nunber sequence

The tracker related difference you report , @arunhep , are largely in plots with ~1 entry where hits go from 0 to 1 or viceversa.

no change in data wf 136.731 as expected.
no change in wf 1001 which is express-like

Confirm the picture.

@franzoni
Copy link

+1

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
Chris, please sign (for addOnTests.py)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 084ff62 into cms-sw:CMSSW_9_2_X Jul 25, 2017
@Martin-Grunewald Martin-Grunewald deleted the HLTMenuV2_92X_auto branch September 7, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants