Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for NoBPTX EXO trigger prompt monitoring #19515

Merged
merged 1 commit into from Jul 6, 2017

Conversation

jalimena
Copy link
Contributor

@jalimena jalimena commented Jul 3, 2017

Fix a minor bug for NoBPTX EXO trigger prompt monitoring.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@mtosi
Copy link
Contributor

mtosi commented Jul 3, 2017

@cmsbulid, please test

@jalimena
Copy link
Contributor Author

jalimena commented Jul 5, 2017

The tests have not run, possibly because @mtosi made a typo in her request... I don't think I have the power...

@jalimena
Copy link
Contributor Author

jalimena commented Jul 5, 2017

@cmsbuild please test

@mtosi
Copy link
Contributor

mtosi commented Jul 5, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21173/console Started: 2017/07/05 11:58

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19515/21173/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1785410
  • DQMHistoTests: Total failures: 44411
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1740833
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6625d2d into cms-sw:master Jul 6, 2017
@jalimena jalimena deleted the NoBPTXExoTriggerDQMBugFix branch November 11, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants