Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon monitoring in 92x release #19520

Closed

Conversation

gomber
Copy link
Contributor

@gomber gomber commented Jul 3, 2017

@fwyzard , @mtosi Here is the PR for the single photon paths corresponding to #18971 in CMSSW_9_2_X release

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

A new Pull Request was created by @gomber for CMSSW_9_2_X.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Jul 3, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21098/console Started: 2017/07/03 16:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19520/21098/summary.html

Comparison Summary:

  • You potentially added 23 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813798
  • DQMHistoTests: Total failures: 29843
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783789
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@gomber
Copy link
Contributor Author

gomber commented Jul 3, 2017

@davidlange6 it is the same code as #18971 but in CMSSW_9_2_X, since that is merged, could you please take care of this too?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@fwyzard
Copy link
Contributor

fwyzard commented Aug 3, 2017

hold

@fwyzard
Copy link
Contributor

fwyzard commented Aug 3, 2017

@gomber can you check if this PR is included #19961 ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2017

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@gomber
Copy link
Contributor Author

gomber commented Aug 3, 2017

@fwyzard as you know, I am away, so checking mails now.
If my answer is still needed, I just checked this PR is already included in the 19961.

@fwyzard
Copy link
Contributor

fwyzard commented Aug 4, 2017

Thanks - can you close this PR, when you have a chance ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants