Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skim on NoBPTX primary dataset for EXO (92X) #19522

Merged
merged 2 commits into from Jul 19, 2017

Conversation

jalimena
Copy link
Contributor

@jalimena jalimena commented Jul 3, 2017

backport of #19521 .
This PR creates a skim on the the NoBPTX dataset for EXO-16-004, EXO-17-004, and HCal DPG noise studies. No event selection criteria are applied, but the event content is greatly reduced from RECO. Furthermore, this skim need only be applied to the NoBPTX dataset, which is already quite small.
The approval talk in the PPD meeting is here: https://indico.cern.ch/event/651440/contributions/2651033/attachments/1489030/2313761/NoBPTXExoSkim_PPDMeeting_6July2017.pdf

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

A new Pull Request was created by @jalimena (Juliette Alimena) for CMSSW_9_2_X.

It involves the following packages:

Configuration/Skimming

@cmsbuild, @kkousour, @davidlange6, @GurpreetSinghChahal, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor

fabozzi commented Jul 3, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21094/console Started: 2017/07/03 16:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19522/21094/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813730
  • DQMHistoTests: Total failures: 44263
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1769301
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Jul 6, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Pull request #19522 was updated. @kkousour, @kpedro88, @fabozzi, @cmsbuild, @GurpreetSinghChahal, @davidlange6 can you please check and sign again.

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 7, 2017

please test workflow 136.735

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21257/console Started: 2017/07/07 17:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Jul 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19522/21257/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1816199
  • DQMHistoTests: Total failures: 14508
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1801525
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@jalimena
Copy link
Contributor Author

hi all, @davidlange6 , this PR has been sitting around for a week, although I think it should be ready to be merged... just making sure it's not forgotten. thanks!

@fabozzi
Copy link
Contributor

fabozzi commented Jul 18, 2017

@jalimena
Do you need the skim to be run in next round of 2016 legacy re-reco with 80X? If so, please provide a 80X backport

@jalimena
Copy link
Contributor Author

no, we should be all set, @fabozzi

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ccec6a0 into cms-sw:CMSSW_9_2_X Jul 19, 2017
@jalimena jalimena deleted the NoBPTXExoSkim92X branch November 11, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants