Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of constituent subtracted jets into heavy ion reconstruction #19537

Merged
merged 9 commits into from Jul 20, 2017

Conversation

mverwe
Copy link
Contributor

@mverwe mverwe commented Jul 4, 2017

This PR replaces #18883

This PR implements Constituent Subtraction for underlying event removal for jets in heavy ion collisions.

Implementation was discussed in Reco and Analysis tools meeting:
https://indico.cern.ch/event/648883/

  1. added possibility to VirtualJetProducer to write the jet and its constituents to the event record. This is relevant since the constituent subtraction is particle-by-particle subtraction and therefore produces a new set of PF candidates.
  2. added the production of background estimates (HiFJRhoProducer) to the heavy ion reconstruction.
  3. CS algo is run with the fastjet contrib package. pT and mass of ghosts is assigned in the CSJetProducer
  4. The Cs jet production for R=0.3 and R=0.4 is added to the standard heavy ion workflow.

The PR was tested on wf 140.53 and 145

A report on this method in heavy ion collision at the JMAR meeting can be found here:
https://indico.cern.ch/event/502737/contributions/2012693/attachments/1237496/1817780/160302_ConstituentSubtraction.pdf

@rappoccio @mandrenguyen @cfmcginn @kurtejung @ahinzmann @knash

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

A new Pull Request was created by @mverwe (Marta Verweij) for master.

It involves the following packages:

RecoHI/HiJetAlgos
RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @schoef, @rappoccio, @jazzitup, @yslai, @nhanvtran, @yenjie, @gkasieczka, @kurtejung, @mariadalfonso, @mandrenguyen, @dgulhan, @seemasharmafnal, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21127/console Started: 2017/07/04 15:12

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2017

@mverwe : could you please modify the title with something more descriptive? The one of the previous PR would be just fine, for example

@mverwe mverwe changed the title Cs integration june20 Integration of constituent subtracted jets into heavy ion reconstruction Jul 4, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19537/21127/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756063
  • DQMHistoTests: Total failures: 88
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1755809
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jul 17, 2017

Timing: on HI workflow 140.53 (2011 PbPb MinBias data) the time added by the new modules is
added +0.00% 0.00 ms/ev -> 0.23 ms/ev hiFJRhoProducer
added +1.29% 0.00 ms/ev -> 186.15 ms/ev akCs4PFJets
added +0.89% 0.00 ms/ev -> 127.88 ms/ev akCs3PFJets
added +0.41% 0.00 ms/ev -> 59.11 ms/ev kt4PFJetsForRho
There are no significant differences in timing of the other modules

@perrotta
Copy link
Contributor

perrotta commented Jul 17, 2017

Overall event size increases by (+0.86%) in that 140.53 worklfow, where the details for the newly added modules are below:

recoPFCandidates_akCs3PFJets_pfParticlesCs_reRECO. 85157.5 5107.39
recoPFCandidates_akCs4PFJets_pfParticlesCs_reRECO. 65386.9 3969.41
recoPFJets_akCs3PFJets__reRECO. 25833.8 4435.81
recoPFJets_akCs4PFJets__reRECO. 16071.4 2718.56
recoPFJets_kt4PFJetsForRho__reRECO. 61713.4 13354.1
doubles_hiFJRhoProducer_etaJets_reRECO. 1266.47 745.571
doubles_hiFJRhoProducer_ptJets_reRECO. 1266.04 704.943
doubles_hiFJRhoProducer_areaJets_reRECO. 1266.9 365.486
doubles_hiFJRhoProducer_mapToRhoM_reRECO. 131.671 122.786
doubles_hiFJRhoProducer_mapToRho_reRECO. 131.243 105.471
doubles_hiFJRhoProducer_mapEtaEdges_reRECO. 140.529 73.6143
doubles_kt4PFJetsForRho_sigmas_reRECO. 162.386 138.457
doubles_kt4PFJetsForRho_rhos_reRECO. 161.529 137.286
double_kt4PFJetsForRho_sigma_reRECO. 65.9857 60.6857
double_kt4PFJetsForRho_rho_reRECO. 65.1286 59.8286
doubles_akCs3PFJets_sigmas_reRECO. 72.6714 65.0286
doubles_akCs4PFJets_sigmas_reRECO. 72.6714 65.0286
doubles_akCs3PFJets_rhos_reRECO. 71.8143 64.1714
doubles_akCs4PFJets_rhos_reRECO. 71.8143 64.1714
double_akCs3PFJets_sigma_reRECO. 64.2714 58.9714
double_akCs4PFJets_sigma_reRECO. 64.2714 58.9714
double_akCs4PFJets_rho_reRECO. 63.4143 58.1143
double_akCs3PFJets_rho_reRECO. 63.4143 58.1143

In the workflow 150.1 (QCD_Pt_80_120, i.e. more jetty) this PR adds 2.7% to the overall event size (step3)

@perrotta
Copy link
Contributor

please test
(the results of the tests seems to be missing...)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21511/console Started: 2017/07/17 10:21

@perrotta
Copy link
Contributor

abort test

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

Pull request #19537 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21608/console Started: 2017/07/19 11:39
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21612/console Started: 2017/07/19 12:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19537/21612/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2293998
  • DQMHistoTests: Total failures: 44342
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2249490
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@perrotta
Copy link
Contributor

+1
Same as #19537 (comment)
Recent fixes and adjustments are fine with reco (once again...)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants