TOP DQM: muon selections for topSingleMediumDQM_MINIAOD are updated #19560
Conversation
|
A new Pull Request was created by @kuyoun for master. It involves the following packages: DQM/Physics @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -373,6 +379,8 @@ void MonitorEnsemble::fill(const edm::Event& event, | |||
| // fill monitoring plots for primary verices | |||
| edm::Handle<edm::View<reco::Vertex> > pvs; | |||
| if (!event.getByToken(pvs_, pvs)) return; | |||
| const reco::Vertex& PV= pvs->front(); | |||
There was a problem hiding this comment.
please start variables with lower case (and in any case avoid variables that differ only by their case)
There was a problem hiding this comment.
I will fix it. BTW, there are more modifications in same code. Is it okay sending new PR? or fix this one first?
| //if (!muonIso_ || (*muonIso_)(*muon)) ++mMultIso; | ||
| if(pfRelIso<0.15)++mMultIso; | ||
|
|
||
| if(!(pfRelIso<0.15 && muon->isGlobalMuon() && muon->isPFMuon() && muon->globalTrack()->normalizedChi2() < 10. && muon->globalTrack()->hitPattern().numberOfValidMuonHits() > 0 && muon->numberOfMatchedStations() > 1 && fabs(muon->muonBestTrack()->dxy(PV.position())) < 0.2 && fabs(muon->muonBestTrack()->dz(PV.position())) < 0.5 && muon->innerTrack()->hitPattern().numberOfValidPixelHits() > 0 && muon->innerTrack()->hitPattern().trackerLayersWithMeasurement() > 5 ) )continue; |
There was a problem hiding this comment.
most of this if statement is repeated just above - which means most criteria are satisfied by definition - those should all be dropped.
second - move the if ( mTight==0) above to avoid unneeded calculations.
There was a problem hiding this comment.
ah - ignore the second comment - I missed that you've filled a histogram of mTight below
|
-1 |
cmsbuild
added
orp-rejected
and removed
orp-pending
comparison-available
dqm-approved
labels
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@kuyoun as far as I can see, differences are all concentrated in the Top sector, as one would expect. Are they compatible with the changes? I see that selections are changed, so I do expect different behaviour... |
|
Would you point out what difference you saw? Could you show plots? Basically, selections have been updated, but I would like to check again. |
|
@kuyoun I was referring to the differences in the test output, now deleted |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
@fabiocos, we had updated selections based on user's requests and had checked that updated selections were filled plots properly. If you saw any empty plots rather than changes compared to the previous version. They were meant to be. You don't worry about. If not, please point out what it is. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Muon id selections are updated.
Lepton phi plot is added.
Muon relIso and its plot are updated.
Muon multiplicity plots are updated as function of tight id,iso selection.
Talk at TOP PAG:
https://indico.cern.ch/event/649877/contributions/2643741/attachments/1487397/2310529/topdqm_jul4.pdf