Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gcc7 compilation of LEDTask #19570

Merged
merged 1 commit into from Jul 6, 2017
Merged

Conversation

davidlange6
Copy link
Contributor

No description provided.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Jul 5, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21182/console Started: 2017/07/05 18:25
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21202/console Started: 2017/07/06 09:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DQM/HcalTasks

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@DryRun, @deguio this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19570/21182/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1786918
  • DQMHistoTests: Total failures: 29365
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1757387
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit fdaea21 into cms-sw:master Jul 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

-1

Tested at: 9fe6463

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5570da4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19570/21202/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19570/21202/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19570/21202/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Jul 6 12:55:22 2017-date Thu Jul 6 12:30:43 2017 s - exit: 35072
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu Jul 6 12:56:26 2017-date Thu Jul 6 12:30:56 2017 s - exit: 34304

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5570da4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19570/21202/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19570/21202/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison job queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants