[93X] Tracker Maps for APV gain payload inspector #19607

mmusich · 2017-07-07T08:37:58Z

Profiting of the technology made available in #19274, we include several types of Tracker Maps of Strip APV gains to be displayed in the Payload Inspector application of the Condition Database Browser @franzoni @arunhep

attn: @dimattia

cmsbuild · 2017-07-07T08:38:17Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @VinInn this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

davidlange6 · 2017-07-07T08:42:48Z

please test

cmsbuild · 2017-07-07T08:43:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21245/console Started: 2017/07/07 11:42

cmsbuild · 2017-07-07T11:08:12Z

+1
Tested at: dfa4c17
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21245/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7c04e1c
68684e0
86d646d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21245/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21245/git-merge-result

cmsbuild · 2017-07-07T11:08:15Z

Comparison job queued.

cmsbuild · 2017-07-07T14:19:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21245/summary.html

Comparison Summary:

You potentially added 8 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1790682
DQMHistoTests: Total failures: 14534
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1775982
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

ggovi · 2017-07-12T09:24:32Z

+1

cmsbuild · 2017-07-12T09:24:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-12T14:19:45Z

CondCore/SiStripPlugins/interface/SiStripPayloadInspectorHelper.h

+
+std::pair<float,float> getTheRange(std::map<uint32_t,float> values){
+
+  std::vector<float> v;


hi @mmusich - please rearrange this to avoid the vector copy of the map.

hi @davidlange6, copy is avoided. Thanks

cmsbuild · 2017-07-12T15:13:08Z

Pull request #19607 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

davidlange6 · 2017-07-12T16:42:48Z

please test

cmsbuild · 2017-07-12T16:43:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21408/console Started: 2017/07/12 18:43

cmsbuild · 2017-07-12T17:56:23Z

+1
Tested at: f094673
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21408/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de56eaa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21408/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21408/git-merge-result

cmsbuild · 2017-07-12T17:56:26Z

Comparison job queued.

cmsbuild · 2017-07-12T19:41:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19607/21408/summary.html

Comparison Summary:

You potentially added 3 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2015567
DQMHistoTests: Total failures: 104
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2015297
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

mmusich · 2017-07-13T15:48:00Z

@ggovi can you please sign again? last update doens't change the output that you've been so kind to test beforehand in the DEMO area of the condDB browser

Posting here a random plot can get be obtained from there:

ggovi · 2017-07-18T08:29:13Z

+1

cmsbuild · 2017-07-18T08:29:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-18T11:33:03Z

+1

mmusich added 5 commits July 7, 2017 09:54

Add TrackerMaps to SiStripApvGain_PaylaodInspector

9cbc2bf

add unit tests

add0f92

add missing include to compile in 9_3_X

30cc00a

Fixing automatic range for ratio of average map as well

da33c70

disable test

dfa4c17

cmsbuild added this to the CMSSW_9_3_X milestone Jul 7, 2017

cmsbuild added comparison-pending db-pending orp-pending pending-signatures tests-pending labels Jul 7, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 7, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 7, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 7, 2017

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jul 12, 2017

davidlange6 reviewed Jul 12, 2017

View reviewed changes

cmsbuild added comparison-pending db-pending pending-signatures tests-pending and removed db-approved fully-signed tests-approved labels Jul 12, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 12, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 12, 2017

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jul 18, 2017

cmsbuild added orp-approved and removed orp-pending labels Jul 18, 2017

cmsbuild merged commit c8e722e into cms-sw:master Jul 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[93X] Tracker Maps for APV gain payload inspector #19607

[93X] Tracker Maps for APV gain payload inspector #19607

mmusich commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

davidlange6 commented Jul 7, 2017

cmsbuild commented Jul 7, 2017 •

edited

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

ggovi commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

davidlange6 Jul 12, 2017

mmusich Jul 12, 2017

cmsbuild commented Jul 12, 2017

davidlange6 commented Jul 12, 2017

cmsbuild commented Jul 12, 2017 •

edited

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

mmusich commented Jul 13, 2017

ggovi commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

davidlange6 commented Jul 18, 2017


		std::pair<float,float> getTheRange(std::map<uint32_t,float> values){

		std::vector<float> v;

[93X] Tracker Maps for APV gain payload inspector #19607

[93X] Tracker Maps for APV gain payload inspector #19607

Conversation

mmusich commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

davidlange6 commented Jul 7, 2017

cmsbuild commented Jul 7, 2017 • edited

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

ggovi commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

davidlange6 Jul 12, 2017

Choose a reason for hiding this comment

mmusich Jul 12, 2017

Choose a reason for hiding this comment

cmsbuild commented Jul 12, 2017

davidlange6 commented Jul 12, 2017

cmsbuild commented Jul 12, 2017 • edited

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

cmsbuild commented Jul 12, 2017

mmusich commented Jul 13, 2017

ggovi commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

davidlange6 commented Jul 18, 2017

cmsbuild commented Jul 7, 2017 •

edited

cmsbuild commented Jul 12, 2017 •

edited