Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T uGT - Parsing of LUTS, Remove unnecessary Warning messages #19619

Merged
merged 2 commits into from Jul 8, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jul 7, 2017

Backport of #19617

Please merge soon, need for patch to 925.

@rekovic
Copy link
Contributor Author

rekovic commented Jul 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21266/console Started: 2017/07/07 19:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

A new Pull Request was created by @rekovic for CMSSW_9_2_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19619/21266/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1816199
  • DQMHistoTests: Total failures: 14915
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1801118
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Jul 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit c30ed18 into cms-sw:CMSSW_9_2_X Jul 8, 2017
@apana apana deleted the apana-add_missingEng_LUTs branch April 10, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants