Run2-sim13 Backport PR #19478 for fixing bug of ECAL simulation

[bsunanda]

Fix the bug in the calculation of the distance of the hit point to the readout unit

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21273/console Started: 2017/07/07 22:04

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_1_X.

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c3c2252
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/21273/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b8616bf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/21273/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/21273/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/21273/summary.html

Comparison Summary:

• You potentially added 856 lines to the logs
• Reco comparison results: 3506 differences found in the comparisons
• DQMHistoTests: Total files compared: 13
• DQMHistoTests: Total histograms compared: 842166
• DQMHistoTests: Total failures: 3107
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 838588
• DQMHistoTests: Total skipped: 468
• DQMHistoTests: Total Missing objects: 0
• Checked 51 log files, 14 edm output root files, 13 DQM output files

[cmsbuild]

Pull request #19625 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21718/console Started: 2017/07/24 18:46

[cmsbuild]

Pull request #19625 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22097/console Started: 2017/08/04 18:10

[bsunanda]

@civanch @davidlange6 I have added the changes so that one can make simulation keeping radiation length information and then doing digitization & reconstruction later on.

[cmsbuild]

+1
Tested at: f0f8e7f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/22097/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
96f4b26
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/22097/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/22097/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19625/22097/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 13
• DQMHistoTests: Total histograms compared: 842166
• DQMHistoTests: Total failures: 3700
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 837998
• DQMHistoTests: Total skipped: 468
• DQMHistoTests: Total Missing objects: 0
• Checked 51 log files, 14 edm output root files, 13 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1