clang check modernize-make-shared #19650

davidlange6 · 2017-07-10T16:22:28Z

for comment about what clang-tidy does to CMSSW (and likely big and not mergeable - this is what clang-tidy check modernize-make-shared does on the tip of CMSSW_9_3_X as of a few days ago

davidlange6 · 2017-07-10T16:24:33Z

please test

cmsbuild · 2017-07-10T16:25:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21314/console Started: 2017/07/10 18:26

cmsbuild · 2017-07-10T16:25:56Z

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CondFormats/JetMETObjects
DQM/Physics
DQMOffline/Trigger
EventFilter/Utilities
FWCore/Framework
L1Trigger/L1TMuon
L1Trigger/L1TMuonOverlap
PhysicsTools/MVATrainer
RecoEcal/EgammaClusterProducers
RecoEcal/EgammaCoreTools
RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/HcalRecAlgos
TopQuarkAnalysis/TopEventProducers

@perrotta, @smuzaffar, @Dr15Jones, @vazzolini, @rekovic, @kmaeshima, @emeschi, @dmitrijus, @cmsbuild, @ggovi, @slava77, @mommsen, @vanbesien, @monttj, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @TaiSakuma, @argiro, @Martin-Grunewald, @thomreis, @seemasharmafnal, @mmarionncern, @kreczko, @imarches, @ahinzmann, @acaudron, @jhgoh, @lgray, @jdolen, @JyothsnaKomaragiri, @ferencek, @trocino, @rociovilar, @Sam-Harper, @rafaellopesdesa, @nhanvtran, @gkasieczka, @schoef, @mmusich, @mtosi, @HuguesBrun, @battibass, @wddgit, @calderona, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-07-10T20:02:24Z

-1

Tested at: 5caea30

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0619998
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21314/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21314/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21314/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Mon Jul 10 21:10:12 2017-date Mon Jul 10 21:06:50 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 21:10:12 2017-date Mon Jul 10 21:06:50 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 21:10:12 2017-date Mon Jul 10 21:06:50 2017 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Mon Jul 10 21:08:58 2017-date Mon Jul 10 21:06:55 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Mon Jul 10 21:09:42 2017-date Mon Jul 10 21:07:00 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 21:09:42 2017-date Mon Jul 10 21:07:00 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 21:09:42 2017-date Mon Jul 10 21:07:00 2017 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Mon Jul 10 21:10:48 2017-date Mon Jul 10 21:08:22 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun2016_MC.root : FAILED - time: date Mon Jul 10 21:14:06 2017-date Mon Jul 10 21:09:07 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 21:14:06 2017-date Mon Jul 10 21:09:07 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_MC.root --fileout file:RelVal_Raw_GRun2016_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 21:14:06 2017-date Mon Jul 10 21:09:07 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Mon Jul 10 21:15:50 2017-date Mon Jul 10 21:10:55 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 21:15:50 2017-date Mon Jul 10 21:10:55 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 21:15:50 2017-date Mon Jul 10 21:10:55 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Mon Jul 10 21:30:56 2017-date Mon Jul 10 21:24:16 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 21:30:56 2017-date Mon Jul 10 21:24:16 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 21:30:56 2017-date Mon Jul 10 21:24:16 2017 s - exit: 21248

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0619998
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21314/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21314/git-merge-result

cmsbuild · 2017-07-10T20:02:27Z

Comparison job queued.

slava77 · 2017-07-11T18:28:25Z

+1

even though the comparisons got stuck this looks OK [better than #19550 in the way that it compiles now]

davidlange6 · 2017-07-14T08:26:48Z

please test

cmsbuild · 2017-07-14T08:27:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21467/console Started: 2017/07/14 10:27

cmsbuild · 2017-07-14T12:22:54Z

-1

Tested at: 5caea30

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2136e02
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21467/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21467/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21467/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2136e02
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21467/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21467/git-merge-result

cmsbuild · 2017-07-14T12:22:56Z

Comparison job queued.

cmsbuild · 2017-07-14T15:25:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21467/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2022761
DQMHistoTests: Total failures: 14925
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2007670
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

Dr15Jones · 2017-07-14T15:30:22Z

+1

dmitrijus · 2017-07-17T08:40:31Z

+1

davidlange6 · 2017-07-18T11:35:53Z

please test

cmsbuild · 2017-07-18T11:36:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21560/console Started: 2017/07/18 13:37

cmsbuild · 2017-07-18T13:24:03Z

+1
Tested at: 5caea30
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21560/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f56dad1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21560/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21560/git-merge-result

cmsbuild · 2017-07-18T13:24:06Z

Comparison job queued.

davidlange6 · 2017-07-18T13:43:21Z

merge

cmsbuild · 2017-07-18T15:27:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19650/21560/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2025409
DQMHistoTests: Total failures: 15037
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2010206
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

clang check modernize-make-shared

5caea30

cmsbuild added this to the CMSSW_9_3_X milestone Jul 10, 2017

cmsbuild added analysis-pending comparison-pending core-pending daq-pending db-pending dqm-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 10, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 10, 2017

cmsbuild added tests-rejected and removed tests-started labels Jul 10, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 11, 2017

cmsbuild added tests-pending and removed tests-rejected labels Jul 14, 2017

cmsbuild removed the tests-pending label Jul 14, 2017

cmsbuild added tests-rejected and removed tests-started labels Jul 14, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 14, 2017

cmsbuild added core-approved and removed core-pending labels Jul 14, 2017

cmsbuild added dqm-approved and removed dqm-pending labels Jul 17, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Jul 18, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 18, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 18, 2017

cmsbuild merged commit 504de00 into cms-sw:master Jul 18, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clang check modernize-make-shared #19650

clang check modernize-make-shared #19650

davidlange6 commented Jul 10, 2017

davidlange6 commented Jul 10, 2017

cmsbuild commented Jul 10, 2017 •

edited

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

slava77 commented Jul 11, 2017

davidlange6 commented Jul 14, 2017

cmsbuild commented Jul 14, 2017 •

edited

cmsbuild commented Jul 14, 2017

cmsbuild commented Jul 14, 2017

cmsbuild commented Jul 14, 2017

Dr15Jones commented Jul 14, 2017

dmitrijus commented Jul 17, 2017

davidlange6 commented Jul 18, 2017

cmsbuild commented Jul 18, 2017 •

edited

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

davidlange6 commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

clang check modernize-make-shared #19650

clang check modernize-make-shared #19650

Conversation

davidlange6 commented Jul 10, 2017

davidlange6 commented Jul 10, 2017

cmsbuild commented Jul 10, 2017 • edited

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

slava77 commented Jul 11, 2017

davidlange6 commented Jul 14, 2017

cmsbuild commented Jul 14, 2017 • edited

cmsbuild commented Jul 14, 2017

cmsbuild commented Jul 14, 2017

cmsbuild commented Jul 14, 2017

Dr15Jones commented Jul 14, 2017

dmitrijus commented Jul 17, 2017

davidlange6 commented Jul 18, 2017

cmsbuild commented Jul 18, 2017 • edited

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

davidlange6 commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 10, 2017 •

edited

cmsbuild commented Jul 14, 2017 •

edited

cmsbuild commented Jul 18, 2017 •

edited